Bug 148426

Summary:

Initial infrastructure for media controls testing

Product:

WebKit

Reporter:

Dean Jackson <dino>

Component:

Media

Assignee:

Dean Jackson <dino>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

148796

Bug Blocks:

Attachments:

Description	Flags
Patch	eric.carlson: review+

Description Dean Jackson 2015-08-25 04:03:07 PDT

Initial infrastructure of media controls testing

Comment 1 Radar WebKit Bug Importer 2015-08-25 04:04:39 PDT

<rdar://problem/22417286>

Comment 2 Dean Jackson 2015-08-25 04:07:50 PDT

Created attachment 259838 [details]
Patch

Comment 3 Eric Carlson 2015-08-25 06:42:52 PDT

Comment on attachment 259838 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=259838&action=review

Great idea, thanks!

> Source/WebCore/html/HTMLMediaElement.cpp:6297
> +    DOMWrapperWorld& world = ensureIsolatedWorld();
> +    ScriptController& scriptController = document().frame()->script();
> +    JSDOMGlobalObject* globalObject = JSC::jsCast<JSDOMGlobalObject*>(scriptController.globalObject(world));
> +    JSC::ExecState* exec = globalObject->globalExec();
> +    JSC::JSLockHolder lock(exec);
> +
> +    JSC::JSValue controllerValue = controllerJSValue(*exec, *globalObject, *this);
> +    JSC::JSObject* controllerObject = controllerValue.toObject(exec);
> +
> +    if (exec->hadException())
> +        return "";
> +

Is there any way to put this into a shared method instead of duplicating it again?

Comment 4 Dean Jackson 2015-08-27 07:47:40 PDT

Committed r189023: <http://trac.webkit.org/changeset/189023>