Bug 148426 – Initial infrastructure for media controls testing

• Component: Media
• Status: RESOLVED FIXED

[Dean Jackson]

Initial infrastructure of media controls testing

[Radar WebKit Bug Importer]

<rdar://problem/22417286>

[Dean Jackson]

Created attachment 259838 [details]
Patch

[Eric Carlson]

Comment on attachment 259838 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=259838&action=review

Great idea, thanks!

> Source/WebCore/html/HTMLMediaElement.cpp:6297
> +    DOMWrapperWorld& world = ensureIsolatedWorld();
> +    ScriptController& scriptController = document().frame()->script();
> +    JSDOMGlobalObject* globalObject = JSC::jsCast<JSDOMGlobalObject*>(scriptController.globalObject(world));
> +    JSC::ExecState* exec = globalObject->globalExec();
> +    JSC::JSLockHolder lock(exec);
> +
> +    JSC::JSValue controllerValue = controllerJSValue(*exec, *globalObject, *this);
> +    JSC::JSObject* controllerObject = controllerValue.toObject(exec);
> +
> +    if (exec->hadException())
> +        return "";
> +

Is there any way to put this into a shared method instead of duplicating it again?

[Dean Jackson]

Committed r189023: <http://trac.webkit.org/changeset/189023>