RESOLVED FIXED 148426
Initial infrastructure for media controls testing 
https://bugs.webkit.org/show_bug.cgi?id=148426
Summary Initial infrastructure for media controls testing
Dean Jackson
Reported 2015-08-25 04:03:07 PDT
Initial infrastructure of media controls testing
Attachments
Patch (8.78 KB, patch)
2015-08-25 04:07 PDT, Dean Jackson 		eric.carlson: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2015-08-25 04:04:39 PDT
<rdar://problem/22417286>
Dean Jackson
Comment 2 2015-08-25 04:07:50 PDT
Created attachment 259838 [details] Patch
Eric Carlson
Comment 3 2015-08-25 06:42:52 PDT
Comment on attachment 259838 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=259838&action=review Great idea, thanks! > Source/WebCore/html/HTMLMediaElement.cpp:6297 > + DOMWrapperWorld& world = ensureIsolatedWorld(); > + ScriptController& scriptController = document().frame()->script(); > + JSDOMGlobalObject* globalObject = JSC::jsCast<JSDOMGlobalObject*>(scriptController.globalObject(world)); > + JSC::ExecState* exec = globalObject->globalExec(); > + JSC::JSLockHolder lock(exec); > + > + JSC::JSValue controllerValue = controllerJSValue(*exec, *globalObject, *this); > + JSC::JSObject* controllerObject = controllerValue.toObject(exec); > + > + if (exec->hadException()) > + return ""; > + Is there any way to put this into a shared method instead of duplicating it again?
Dean Jackson
Comment 4 2015-08-27 07:47:40 PDT
Committed r189023: <http://trac.webkit.org/changeset/189023>
Note You need to log in before you can comment on or make changes to this bug.