Bug 148426 - Initial infrastructure for media controls testing
Summary: Initial infrastructure for media controls testing
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dean Jackson
URL:
Keywords: InRadar
Depends on: 148796
Blocks:
  Show dependency treegraph
 
Reported: 2015-08-25 04:03 PDT by Dean Jackson
Modified: 2015-09-04 04:51 PDT (History)
1 user (show)

See Also:


Attachments
Patch (8.78 KB, patch)
2015-08-25 04:07 PDT, Dean Jackson
eric.carlson: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dean Jackson 2015-08-25 04:03:07 PDT
Initial infrastructure of media controls testing
Comment 1 Radar WebKit Bug Importer 2015-08-25 04:04:39 PDT
<rdar://problem/22417286>
Comment 2 Dean Jackson 2015-08-25 04:07:50 PDT
Created attachment 259838 [details]
Patch
Comment 3 Eric Carlson 2015-08-25 06:42:52 PDT
Comment on attachment 259838 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=259838&action=review

Great idea, thanks!

> Source/WebCore/html/HTMLMediaElement.cpp:6297
> +    DOMWrapperWorld& world = ensureIsolatedWorld();
> +    ScriptController& scriptController = document().frame()->script();
> +    JSDOMGlobalObject* globalObject = JSC::jsCast<JSDOMGlobalObject*>(scriptController.globalObject(world));
> +    JSC::ExecState* exec = globalObject->globalExec();
> +    JSC::JSLockHolder lock(exec);
> +
> +    JSC::JSValue controllerValue = controllerJSValue(*exec, *globalObject, *this);
> +    JSC::JSObject* controllerObject = controllerValue.toObject(exec);
> +
> +    if (exec->hadException())
> +        return "";
> +

Is there any way to put this into a shared method instead of duplicating it again?
Comment 4 Dean Jackson 2015-08-27 07:47:40 PDT
Committed r189023: <http://trac.webkit.org/changeset/189023>