Bug 148410

Summary:

Fix crash due to search field disappearing when showing results menu

Product:

WebKit

Reporter:

Wenson Hsieh <wenson_hsieh>

Component:

WebCore Misc.

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Mac

OS:

Unspecified

Attachments:

Description	Flags
Click on the results button to crash WebKit	none
Patch	none
Patch	none

Wenson Hsieh

Reported 2015-08-24 18:25:44 PDT

Created attachment 259800 [details] Click on the results button to crash WebKit When an input of type search has a results attribute and is set up to disappear (e.g. display: none) when focused, clicking on the search field will crash WebKit since we assume that, after running the handler code, the search field's renderer will still exist. We use the renderer to then toggle the search results popup. This fix guards this logic with a check to make sure that the renderer still exists when handling an event on the search field results button.

Attachments
Click on the results button to crash WebKit (327 bytes, text/html) 2015-08-24 18:25 PDT, Wenson Hsieh	no flags	Details
Patch (3.74 KB, patch) 2015-08-24 22:49 PDT, Wenson Hsieh	no flags	Details Formatted Diff Diff
Patch (4.96 KB, patch) 2015-08-25 09:21 PDT, Wenson Hsieh	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.