RESOLVED FIXED 148410
Fix crash due to search field disappearing when showing results menu 
https://bugs.webkit.org/show_bug.cgi?id=148410
Summary Fix crash due to search field disappearing when showing results menu
Wenson Hsieh
Reported 2015-08-24 18:25:44 PDT
Created attachment 259800 [details] Click on the results button to crash WebKit When an input of type search has a results attribute and is set up to disappear (e.g. display: none) when focused, clicking on the search field will crash WebKit since we assume that, after running the handler code, the search field's renderer will still exist. We use the renderer to then toggle the search results popup. This fix guards this logic with a check to make sure that the renderer still exists when handling an event on the search field results button.
Attachments
Click on the results button to crash WebKit (327 bytes, text/html)
2015-08-24 18:25 PDT, Wenson Hsieh 		no flags
Details
Patch (3.74 KB, patch)
2015-08-24 22:49 PDT, Wenson Hsieh 		no flags
DetailsFormatted DiffDiff
Patch (4.96 KB, patch)
2015-08-25 09:21 PDT, Wenson Hsieh 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Wenson Hsieh
Comment 1 2015-08-24 18:26:17 PDT
<rdar://problem/22399850>
Wenson Hsieh
Comment 2 2015-08-24 22:49:09 PDT
Created attachment 259827 [details] Patch
Wenson Hsieh
Comment 3 2015-08-25 09:21:38 PDT
Created attachment 259852 [details] Patch
Brent Fulgham
Comment 4 2015-08-25 10:48:54 PDT
Comment on attachment 259852 [details] Patch Very nice! r=me.
WebKit Commit Bot
Comment 5 2015-08-25 11:00:18 PDT
Comment on attachment 259852 [details] Patch Clearing flags on attachment: 259852 Committed r188918: <http://trac.webkit.org/changeset/188918>
WebKit Commit Bot
Comment 6 2015-08-25 11:00:21 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.