Summary: | [Win] Cleanup some Windows WebCore files | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Brent Fulgham <bfulgham> | ||||
Component: | WebCore Misc. | Assignee: | Brent Fulgham <bfulgham> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | bfulgham, commit-queue, dino | ||||
Priority: | P2 | ||||||
Version: | WebKit Nightly Build | ||||||
Hardware: | PC | ||||||
OS: | Windows 8 | ||||||
Bug Depends on: | 148240 | ||||||
Bug Blocks: | |||||||
Attachments: |
|
Description
Brent Fulgham
2015-08-20 17:56:55 PDT
Created attachment 259545 [details]
Patch
Attachment 259545 [details] did not pass style-queue:
ERROR: Source/WebCore/platform/win/PopupMenuWin.cpp:1154: AccessiblePopupMenu::get_accParent is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4]
ERROR: Source/WebCore/platform/win/PopupMenuWin.cpp:1163: AccessiblePopupMenu::get_accChildCount is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4]
ERROR: Source/WebCore/platform/win/PopupMenuWin.cpp:1172: AccessiblePopupMenu::get_accChild is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4]
ERROR: Source/WebCore/platform/win/PopupMenuWin.cpp:1186: AccessiblePopupMenu::get_accName is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4]
ERROR: Source/WebCore/platform/win/PopupMenuWin.cpp:1191: AccessiblePopupMenu::get_accValue is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4]
ERROR: Source/WebCore/platform/win/PopupMenuWin.cpp:1212: AccessiblePopupMenu::get_accDescription is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4]
ERROR: Source/WebCore/platform/win/PopupMenuWin.cpp:1218: AccessiblePopupMenu::get_accRole is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4]
ERROR: Source/WebCore/platform/win/PopupMenuWin.cpp:1237: AccessiblePopupMenu::get_accState is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4]
ERROR: Source/WebCore/platform/win/PopupMenuWin.cpp:1251: AccessiblePopupMenu::get_accHelp is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4]
ERROR: Source/WebCore/platform/win/PopupMenuWin.cpp:1257: AccessiblePopupMenu::get_accKeyboardShortcut is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4]
ERROR: Source/WebCore/platform/win/PopupMenuWin.cpp:1263: AccessiblePopupMenu::get_accFocus is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4]
ERROR: Source/WebCore/platform/win/PopupMenuWin.cpp:1269: AccessiblePopupMenu::get_accSelection is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4]
ERROR: Source/WebCore/platform/win/PopupMenuWin.cpp:1275: AccessiblePopupMenu::get_accDefaultAction is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4]
ERROR: Source/WebCore/platform/win/PopupMenuWin.cpp:1420: AccessiblePopupMenu::get_accHelpTopic is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4]
ERROR: Source/WebCore/platform/win/WCDataObject.cpp:212: Multi line control clauses should use braces. [whitespace/braces] [4]
Total errors found: 15 in 8 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Whoops! I never landed this! Committed r194535: <http://trac.webkit.org/changeset/194535> |