Bug 148261

Summary:

[iOS] Emoji's descent is way too large

Product:

WebKit

Reporter:

Myles C. Maxfield <mmaxfield>

Component:

New Bugs

Assignee:

Myles C. Maxfield <mmaxfield>

Status:

RESOLVED INVALID

Severity:

Normal

CC:

dino, enrica, jonlee, simon.fraser, thorton, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	simon.fraser: review+

Description Myles C. Maxfield 2015-08-20 16:08:05 PDT

Emoji's descent is way too large

Comment 1 Myles C. Maxfield 2015-08-20 16:18:45 PDT

Created attachment 259515 [details]
Patch

Comment 2 Myles C. Maxfield 2015-08-20 16:21:08 PDT

Comment on attachment 259515 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=259515&action=review

> Source/WebCore/platform/graphics/cocoa/FontCocoa.mm:-275
> -    if (m_platformData.isEmoji()) {

This should match the size clamping code too

Comment 3 Myles C. Maxfield 2015-08-20 17:43:38 PDT

Created attachment 259541 [details]
Patch

Comment 4 Myles C. Maxfield 2015-08-20 17:45:36 PDT

<rdar://problem/22194708>

Comment 5 Myles C. Maxfield 2015-08-20 18:26:15 PDT

This is no longer necessary because of https://bugs.webkit.org/show_bug.cgi?id=148265

Comment 6 Myles C. Maxfield 2015-08-20 19:13:52 PDT

Fixed by r188737