Bug 148228

Summary:

A watchdog tests is failing on Windows

Product:

WebKit

Reporter:

Mark Lam <mark.lam>

Component:

JavaScriptCore

Assignee:

Mark Lam <mark.lam>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bfulgham, commit-queue

Priority:

Version:

WebKit Local Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
the fix.	none

Description Mark Lam 2015-08-20 09:42:59 PDT

Because of Window's low resolution timer, the failing test's time targets were not met.  By giving the test a little more time, the failure was resolved.

Comment 1 Mark Lam 2015-08-20 09:50:04 PDT

Created attachment 259475 [details]
the fix.

Comment 2 Brent Fulgham 2015-08-20 09:56:49 PDT

Comment on attachment 259475 [details]
the fix.

I wonder if we can figure out some kind of threshold to use to support Windows in future tests.

Thank you for figuring this out!

r=me.

Comment 3 WebKit Commit Bot 2015-08-20 10:41:52 PDT

Comment on attachment 259475 [details]
the fix.

Clearing flags on attachment: 259475

Committed r188689: <http://trac.webkit.org/changeset/188689>

Comment 4 WebKit Commit Bot 2015-08-20 10:41:55 PDT

All reviewed patches have been landed.  Closing bug.