Summary: | Web Inspector: Uncaught Exceptions regarding PseudoElements / TemplateContent | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Joseph Pecoraro <joepeck> | ||||||
Component: | Web Inspector | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | bburg, commit-queue, graouts, joepeck, mattbaker, nvasilyev, timothy, webkit-bug-importer | ||||||
Priority: | P2 | Keywords: | DoNotImportToRadar | ||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | All | ||||||||
OS: | All | ||||||||
Attachments: |
|
Description
Joseph Pecoraro
2015-08-19 14:00:03 PDT
Created attachment 259402 [details]
[PATCH] Proposed Fix
Comment on attachment 259402 [details] [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=259402&action=review r=me > Source/WebInspectorUI/ChangeLog:14 > + exists, it may be null. So separate the two pathes. paths* > Source/WebInspectorUI/UserInterface/Controllers/DOMTreeManager.js:289 > + for (let i = 0; node.children && i < node.children.length; ++i) This could be for (let .. of ..), since it doesn't mutate node.children. > Source/WebInspectorUI/UserInterface/Controllers/DOMTreeManager.js:296 > + let pseudoElements = node.pseudoElements(); No need for a local. Created attachment 259430 [details]
[PATCH] For Landing
Comment on attachment 259430 [details] [PATCH] For Landing Clearing flags on attachment: 259430 Committed r188670: <http://trac.webkit.org/changeset/188670> This landed, see above comment. |