Bug 148169

Summary: functions that use try/catch will allocate a top level JSLexicalEnvironment even when it is not necessary
Product: WebKit Reporter: Saam Barati <saam>
Component: JavaScriptCoreAssignee: Saam Barati <saam>
Status: RESOLVED FIXED    
Severity: Normal CC: basile_clement, benjamin, commit-queue, fpizlo, ggaren, mark.lam, mmirman, msaboff, oliver, ysuzuki
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch
none
patch none

Saam Barati
Reported 2015-08-19 00:19:12 PDT
Even if no "var"s need to go into the environment, byte code will create one. This is probably an easy parser/bytecodegenerator change to fix.
Attachments
patch (6.50 KB, patch)
2015-09-14 18:59 PDT, Saam Barati 		no flags
DetailsFormatted DiffDiff
patch (6.79 KB, patch)
2015-09-14 19:08 PDT, Saam Barati 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Saam Barati
Comment 1 2015-09-14 18:59:50 PDT
Created attachment 261160 [details] patch
Saam Barati
Comment 2 2015-09-14 19:08:34 PDT
Created attachment 261161 [details] patch
Geoffrey Garen
Comment 3 2015-09-15 11:11:33 PDT
Comment on attachment 261161 [details] patch r=me
WebKit Commit Bot
Comment 4 2015-09-15 12:26:59 PDT
Comment on attachment 261161 [details] patch Clearing flags on attachment: 261161 Committed r189819: <http://trac.webkit.org/changeset/189819>
WebKit Commit Bot
Comment 5 2015-09-15 12:27:04 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.