| Summary: | Add metadata to Dashboard.Repository for SCM type. | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Jason Marcell <jmarcell> | ||||
| Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> | ||||
| Status: | RESOLVED INVALID | ||||||
| Severity: | Normal | CC: | adele, ap, bburg, dbates, dean_johnson, jake.nielsen.webkit, jmarcell | ||||
| Priority: | P2 | ||||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Jason Marcell
2015-08-18 14:26:16 PDT
Created attachment 259297 [details]
Patch
Comment on attachment 259297 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=259297&action=review > Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:28 > + GIT: 1 Should this be GIT in all caps? For that matter, is SVN an appropriate key for Subversion? > Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:32 > + SCMTypes: SCMTypes, I defined SCMTypes outside of Dashboard so that I could refer to it in the Dashboard.Repository section. But I also want to refer to them as Dashboard.SCMTypes.SVN, etc., so I added a key "SCMTypes" here. I don't really like this, but I'm open to other suggestions. We went with this instead: https://bugs.webkit.org/attachment.cgi?id=259779 Comment on attachment 259297 [details] Patch Cleared review? from attachment 259297 [details] so that this bug does not appear in http://webkit.org/pending-review. If you would like this patch reviewed, please attach it to a new bug (or re-open this bug before marking it for review again). |