Bug 148142

Summary: Add metadata to Dashboard.Repository for SCM type.
Product: WebKit Reporter: Jason Marcell <jmarcell>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED INVALID    
Severity: Normal CC: adele, ap, bburg, dbates, dean_johnson, jake.nielsen.webkit, jmarcell
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Jason Marcell
Reported 2015-08-18 14:26:16 PDT
Add metadata to Dashboard.Repository for SCM type.
Attachments
Patch (1.87 KB, patch)
2015-08-18 14:29 PDT, Jason Marcell 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Jason Marcell
Comment 1 2015-08-18 14:29:59 PDT
Created attachment 259297 [details] Patch
Jason Marcell
Comment 2 2015-08-18 14:33:56 PDT
Comment on attachment 259297 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=259297&action=review > Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:28 > + GIT: 1 Should this be GIT in all caps? For that matter, is SVN an appropriate key for Subversion? > Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:32 > + SCMTypes: SCMTypes, I defined SCMTypes outside of Dashboard so that I could refer to it in the Dashboard.Repository section. But I also want to refer to them as Dashboard.SCMTypes.SVN, etc., so I added a key "SCMTypes" here. I don't really like this, but I'm open to other suggestions.
Jason Marcell
Comment 3 2015-08-27 17:13:16 PDT
We went with this instead: https://bugs.webkit.org/attachment.cgi?id=259779
Csaba Osztrogonác
Comment 4 2015-09-14 10:59:48 PDT
Comment on attachment 259297 [details] Patch Cleared review? from attachment 259297 [details] so that this bug does not appear in http://webkit.org/pending-review. If you would like this patch reviewed, please attach it to a new bug (or re-open this bug before marking it for review again).
Note You need to log in before you can comment on or make changes to this bug.