Bug 148140

Summary: Replace all uses of std::mutex/std::condition_variable with WTF::Lock/WTF::Condition
Product: WebKit Reporter: Filip Pizlo <fpizlo>
Component: Web Template FrameworkAssignee: Filip Pizlo <fpizlo>
Status: RESOLVED FIXED    
Severity: Normal CC: barraclough, basile_clement, benjamin, commit-queue, ggaren, mark.lam, mhahnenb, mmirman, msaboff, nrotem, oliver, saam, sam
Priority: P2    
Version: Other   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 147841, 157924    
Attachments:
Description Flags
work so far
none
it is written
none
the patch
none
the patch
none
the patch ggaren: review+

Description Filip Pizlo 2015-08-18 14:08:27 PDT 
WTF's locking primitives are way faster and way smaller.  We should use those always.
Comment 1 Filip Pizlo 2015-08-18 17:46:01 PDT 
Created attachment 259335 [details]
work so far
Comment 2 Filip Pizlo 2015-08-18 18:57:00 PDT 
Created attachment 259340 [details]
it is written
Comment 3 Filip Pizlo 2015-08-18 20:50:32 PDT 
Created attachment 259345 [details]
the patch
Comment 4 WebKit Commit Bot 2015-08-18 20:53:25 PDT 
Attachment 259345 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/network/cf/LoaderRunLoopCF.cpp:81:  More than one command on the same line  [whitespace/newline] [4]
Total errors found: 1 in 66 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 5 Filip Pizlo 2015-08-18 21:21:21 PDT 
Created attachment 259349 [details]
the patch

Fix more builds
Comment 6 WebKit Commit Bot 2015-08-18 21:23:48 PDT 
Attachment 259349 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/network/cf/LoaderRunLoopCF.cpp:82:  More than one command on the same line  [whitespace/newline] [4]
Total errors found: 1 in 66 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 7 Filip Pizlo 2015-08-18 22:01:36 PDT 
Created attachment 259353 [details]
the patch
Comment 8 WebKit Commit Bot 2015-08-18 22:04:32 PDT 
Attachment 259353 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/network/cf/LoaderRunLoopCF.cpp:83:  More than one command on the same line  [whitespace/newline] [4]
Total errors found: 1 in 66 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 9 Geoffrey Garen 2015-08-19 11:06:57 PDT 
Comment on attachment 259353 [details]
the patch

r=me
Comment 10 Filip Pizlo 2015-08-19 11:18:49 PDT 
Landed in http://trac.webkit.org/changeset/188642