Summary: | [CMake] REGRESSION(r188540): WebKitTestRunner is not longer built and all the tests (layout and perf) fail. | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Carlos Alberto Lopez Perez <clopez> | ||||||
Component: | WebKitGTK | Assignee: | Alex Christensen <achristensen> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Critical | CC: | achristensen, bfulgham, calvaris, mcatanzaro, ossy, pnormand | ||||||
Priority: | P1 | ||||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Carlos Alberto Lopez Perez
2015-08-18 04:48:46 PDT
Created attachment 259284 [details]
Patch
Woah, my bad. Does this fix it? Created attachment 259285 [details]
Patch
(In reply to comment #4) > http://trac.webkit.org/changeset/188589 And this broke the GTK build :( [12/157] Linking CXX executable bin/WebKitTestRunner FAILED: : && /usr/lib/ccache/clang++ -std=c++11 -fcolor-diagnostics -Qunused-arguments -O3 -DNDEBUG -fno-exceptions -fno-strict-aliasing -fno-rtti -L/home/clopez/webkit/webkit/WebKitBuild/DependenciesGTK/Root/lib64 -fuse-ld=gold -Wl,--disable-new-dtags @CMakeFiles/WebKitTestRunner.rsp -o bin/WebKitTestRunner && : Tools/WebKitTestRunner/CMakeFiles/WebKitTestRunner.dir/TestController.cpp.o:/home/clopez/webkit/.ccache/tmp/TestContro.tmp.trinity.14155.ii:function WTR::TestController::ensureViewSupportsOptionsForTest(WTR::TestInvocation const&): error: undefined reference to 'WTR::TestController::updatePlatformSpecificViewOptionsForTest(WTR::ViewOptions&, WTR::TestInvocation const&) const' Tools/WebKitTestRunner/CMakeFiles/WebKitTestRunner.dir/TestController.cpp.o:/home/clopez/webkit/.ccache/tmp/TestContro.tmp.trinity.14155.ii:function WTR::TestController::viewOptionsForTest(WTR::TestInvocation const&) const: error: undefined reference to 'WTR::TestController::updatePlatformSpecificViewOptionsForTest(WTR::ViewOptions&, WTR::TestInvocation const&) const' clang: error: linker command failed with exit code 1 (use -v to see invocation) ninja: build stopped: subcommand failed. https://build.webkit.org/builders/GTK%20Linux%2064-bit%20Release%20%28Build%29/builds/61366/steps/compile-webkit/logs/stdio Ok.... The build error is unrelated to this CMake issue. Your last patch fixed the CMake issue that uncovered the build error caused by r188548 that was previously unnoticed Reported the build error here: https://bugs.webkit.org/show_bug.cgi?id=148154 Closing this |