Bug 14810 – [gtk] [patch] Bad n_params on load_finished's g_signal_new in webkitgtkpage.cpp

• Component: WebKit API
• Status: RESOLVED FIXED

[Diego Escalante Urrelo]

In webkitgtkpage.cpp:

--- gtk/Api/webkitgtkpage.cpp   (revision 24766)
+++ gtk/Api/webkitgtkpage.cpp   (working copy)
@@ -215,8 +215,8 @@ static void webkit_gtk_page_class_init(W
             NULL,
             NULL,
             webkit_gtk_marshal_VOID__OBJECT_BOOLEAN,
-            G_TYPE_NONE, 1,
-            WEBKIT_GTK_TYPE_FRAME);
+            G_TYPE_NONE, 2,
+            WEBKIT_GTK_TYPE_FRAME, G_TYPE_BOOLEAN);

[Diego Escalante Urrelo]

Created attachment 15736 [details]
The patch with a corresponding changelog entry

:)

[Alp Toker]

Comment on attachment 15736 [details]
The patch with a corresponding changelog entry

Thanks! Note that I've fixed up the ChangeLog entry a little to match formatting conventions and made the log a bit more descriptive before landing this patch.

[Diego Escalante Urrelo]

Created attachment 15737 [details]
Fixes class_offset argument of various signals

An updated version.

[Alp Toker]

Comment on attachment 15737 [details]
Fixes class_offset argument of various signals

This one fixes the remaining issues (except for one of the signals, the fix for which I've added to the patch). It also modifies the formatting of the previous ChangeLog entry by mistake, a change which I've removed.