Bug 14810 - [gtk] [patch] Bad n_params on load_finished's g_signal_new in webkitgtkpage.cpp
Summary: [gtk] [patch] Bad n_params on load_finished's g_signal_new in webkitgtkpage.cpp
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit API (show other bugs)
Version: 523.x (Safari 3)
Hardware: PC Linux
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-07-29 18:53 PDT by Diego Escalante Urrelo
Modified: 2007-07-29 21:08 PDT (History)
1 user (show)

See Also:


Attachments
The patch with a corresponding changelog entry (1.04 KB, patch)
2007-07-29 19:39 PDT, Diego Escalante Urrelo
alp: review+
Details | Formatted Diff | Diff
Fixes class_offset argument of various signals (5.44 KB, patch)
2007-07-29 20:48 PDT, Diego Escalante Urrelo
alp: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Diego Escalante Urrelo 2007-07-29 18:53:50 PDT
In webkitgtkpage.cpp:

--- gtk/Api/webkitgtkpage.cpp   (revision 24766)
+++ gtk/Api/webkitgtkpage.cpp   (working copy)
@@ -215,8 +215,8 @@ static void webkit_gtk_page_class_init(W
             NULL,
             NULL,
             webkit_gtk_marshal_VOID__OBJECT_BOOLEAN,
-            G_TYPE_NONE, 1,
-            WEBKIT_GTK_TYPE_FRAME);
+            G_TYPE_NONE, 2,
+            WEBKIT_GTK_TYPE_FRAME, G_TYPE_BOOLEAN);
Comment 1 Diego Escalante Urrelo 2007-07-29 19:39:31 PDT
Created attachment 15736 [details]
The patch with a corresponding changelog entry

:)
Comment 2 Alp Toker 2007-07-29 20:09:17 PDT
Comment on attachment 15736 [details]
The patch with a corresponding changelog entry

Thanks! Note that I've fixed up the ChangeLog entry a little to match formatting conventions and made the log a bit more descriptive before landing this patch.
Comment 3 Diego Escalante Urrelo 2007-07-29 20:48:45 PDT
Created attachment 15737 [details]
Fixes class_offset argument of various signals

An updated version.
Comment 4 Alp Toker 2007-07-29 21:08:42 PDT
Comment on attachment 15737 [details]
Fixes class_offset argument of various signals

This one fixes the remaining issues (except for one of the signals, the fix for which I've added to the patch). It also modifies the formatting of the previous ChangeLog entry by mistake, a change which I've removed.