| Summary: | Web Inspector: InspectorTest should be a subclass of TestHarness | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | BJ Burg <bburg> | ||||||||
| Component: | Web Inspector | Assignee: | BJ Burg <bburg> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | bburg, commit-queue, graouts, joepeck, mattbaker, nvasilyev, timothy, webkit-bug-importer | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | WebKit Nightly Build | ||||||||||
| Hardware: | All | ||||||||||
| OS: | All | ||||||||||
| Bug Depends on: | 148122 | ||||||||||
| Bug Blocks: | 147934 | ||||||||||
| Attachments: |
|
||||||||||
|
Description
BJ Burg
2015-08-17 09:22:13 PDT
Created attachment 259168 [details]
Proposed Fix
Created attachment 259194 [details]
Proposed Fix (EWS)
Comment on attachment 259194 [details] Proposed Fix (EWS) View in context: https://bugs.webkit.org/attachment.cgi?id=259194&action=review > Source/WebInspectorUI/UserInterface/Test.html:150 > + // Not reliable unless console messages are dumped to stderr. See wiki for details. Is there a wiki link that could be added here? Comment on attachment 259194 [details] Proposed Fix (EWS) Clearing flags on attachment: 259194 Committed r188552: <http://trac.webkit.org/changeset/188552> All reviewed patches have been landed. Closing bug. Re-opened since this is blocked by bug 148122 Created attachment 259376 [details]
Proposed Fix (arrow it)
Comment on attachment 259376 [details] Proposed Fix (arrow it) View in context: https://bugs.webkit.org/attachment.cgi?id=259376&action=review > Source/WebInspectorUI/UserInterface/Test/FrontendTestHarness.js:123 > + return () => { this.addResult(type + ": " + Array.from(arguments).join(" ")); }; `` > LayoutTests/inspector/debugger/breakpoint-action-eval.html:16 > + TestPage.addResult("Breakpoint action evaluated. a:(" + a + ") b:(" + b + ")"); `` > LayoutTests/inspector/debugger/resources/script-for-breakpoint-actions.js:4 > + TestPage.addResult("inside breakpointActions a:(" + a + ") b:(" + b + ")"); `` > LayoutTests/inspector/timeline/debugger-paused-while-recording.html:18 > + TestPage.addResult("Calling add(): " + a + " + " + b); `` > LayoutTests/inspector/timeline/debugger-paused-while-recording.html:24 > + TestPage.addResult("Calling mul(): " + a + " * " + b); `` > LayoutTests/inspector/timeline/exception-in-injected-script-while-recording.html:18 > + TestPage.addResult("Calling add(): " + a + " + " + b); `` > LayoutTests/inspector/timeline/exception-in-injected-script-while-recording.html:24 > + TestPage.addResult("Calling mul(): " + a + " * " + b); `` Committed r188644: <http://trac.webkit.org/changeset/188644> |