Bug 148079

Summary: Web Inspector: InspectorTest should be a subclass of TestHarness
Product: WebKit Reporter: Blaze Burg <bburg>
Component: Web InspectorAssignee: Blaze Burg <bburg>
Status: RESOLVED FIXED    
Severity: Normal CC: bburg, commit-queue, graouts, joepeck, mattbaker, nvasilyev, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Bug Depends on: 148122    
Bug Blocks: 147934    
Attachments:
Description Flags
Proposed Fix
none
Proposed Fix (EWS)
none
Proposed Fix (arrow it) timothy: review+

Blaze Burg
Reported 2015-08-17 09:22:13 PDT
,
Attachments
Proposed Fix (29.21 KB, patch)
2015-08-17 11:49 PDT, Blaze Burg 		no flags
DetailsFormatted DiffDiff
Proposed Fix (EWS) (29.49 KB, patch)
2015-08-17 15:05 PDT, Blaze Burg 		no flags
DetailsFormatted DiffDiff
Proposed Fix (arrow it) (35.29 KB, patch)
2015-08-19 10:34 PDT, Blaze Burg 		timothy: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2015-08-17 09:22:28 PDT
<rdar://problem/22308113>
Blaze Burg
Comment 2 2015-08-17 11:49:12 PDT
Created attachment 259168 [details] Proposed Fix
Blaze Burg
Comment 3 2015-08-17 15:05:28 PDT
Created attachment 259194 [details] Proposed Fix (EWS)
Matt Baker
Comment 4 2015-08-17 15:21:02 PDT
Comment on attachment 259194 [details] Proposed Fix (EWS) View in context: https://bugs.webkit.org/attachment.cgi?id=259194&action=review > Source/WebInspectorUI/UserInterface/Test.html:150 > + // Not reliable unless console messages are dumped to stderr. See wiki for details. Is there a wiki link that could be added here?
WebKit Commit Bot
Comment 5 2015-08-17 16:37:12 PDT
Comment on attachment 259194 [details] Proposed Fix (EWS) Clearing flags on attachment: 259194 Committed r188552: <http://trac.webkit.org/changeset/188552>
WebKit Commit Bot
Comment 6 2015-08-17 16:37:16 PDT
All reviewed patches have been landed. Closing bug.
WebKit Commit Bot
Comment 7 2015-08-17 23:29:49 PDT
Re-opened since this is blocked by bug 148122
Alexey Proskuryakov
Comment 8 2015-08-17 23:35:52 PDT
Rolled out because this depended on r188539.
Blaze Burg
Comment 9 2015-08-19 10:34:01 PDT
Created attachment 259376 [details] Proposed Fix (arrow it)
Timothy Hatcher
Comment 10 2015-08-19 11:53:03 PDT
Comment on attachment 259376 [details] Proposed Fix (arrow it) View in context: https://bugs.webkit.org/attachment.cgi?id=259376&action=review > Source/WebInspectorUI/UserInterface/Test/FrontendTestHarness.js:123 > + return () => { this.addResult(type + ": " + Array.from(arguments).join(" ")); }; `` > LayoutTests/inspector/debugger/breakpoint-action-eval.html:16 > + TestPage.addResult("Breakpoint action evaluated. a:(" + a + ") b:(" + b + ")"); `` > LayoutTests/inspector/debugger/resources/script-for-breakpoint-actions.js:4 > + TestPage.addResult("inside breakpointActions a:(" + a + ") b:(" + b + ")"); `` > LayoutTests/inspector/timeline/debugger-paused-while-recording.html:18 > + TestPage.addResult("Calling add(): " + a + " + " + b); `` > LayoutTests/inspector/timeline/debugger-paused-while-recording.html:24 > + TestPage.addResult("Calling mul(): " + a + " * " + b); `` > LayoutTests/inspector/timeline/exception-in-injected-script-while-recording.html:18 > + TestPage.addResult("Calling add(): " + a + " + " + b); `` > LayoutTests/inspector/timeline/exception-in-injected-script-while-recording.html:24 > + TestPage.addResult("Calling mul(): " + a + " * " + b); ``
Blaze Burg
Comment 11 2015-08-19 12:09:47 PDT
Committed r188644: <http://trac.webkit.org/changeset/188644>
Note You need to log in before you can comment on or make changes to this bug.