Summary: | Fix conversion-null warning in conversion.cpp of TestWebKitAPI | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Gyuyoung Kim <gyuyoung.kim> | ||||||
Component: | Tools / Tests | Assignee: | Gyuyoung Kim <gyuyoung.kim> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | ap, commit-queue | ||||||
Priority: | P2 | ||||||||
Version: | WebKit Local Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Gyuyoung Kim
2015-08-16 19:22:42 PDT
Created attachment 259134 [details]
Patch
Comment on attachment 259134 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=259134&action=review > Tools/TestWebKitAPI/Tests/WTF/Condition.cpp:253 > - EXPECT_EQ(false, result); > + EXPECT_EQ(result, false); According to documentation, the order is correct: EXPECT_EQ(expected, actual). This needs a different fix. Created attachment 259258 [details]
Patch
(In reply to comment #2) > Comment on attachment 259134 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=259134&action=review > > > Tools/TestWebKitAPI/Tests/WTF/Condition.cpp:253 > > - EXPECT_EQ(false, result); > > + EXPECT_EQ(result, false); > > According to documentation, the order is correct: EXPECT_EQ(expected, > actual). This needs a different fix. Yes, we should use EXPECT_FALSE|TRUE when checking boolean instead of EXPECT_EQ. Comment on attachment 259258 [details] Patch Clearing flags on attachment: 259258 Committed r188618: <http://trac.webkit.org/changeset/188618> All reviewed patches have been landed. Closing bug. |