Bug 148065

Summary:

Holes for find matches that span multiple lines are completely wrong

Product:

WebKit

Reporter:

Tim Horton <thorton>

Component:

New Bugs

Assignee:

Tim Horton <thorton>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

mitz, mmaxfield, sam, simon.fraser

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	simon.fraser: review+

Description Tim Horton 2015-08-16 01:51:44 PDT

Holes for find matches that span multiple lines are completely wrong

Comment 1 Tim Horton 2015-08-16 01:52:14 PDT

Created attachment 259118 [details]
Patch

Comment 2 Tim Horton 2015-08-16 01:57:19 PDT

Created attachment 259119 [details]
Patch

Comment 3 Tim Horton 2015-08-16 02:02:05 PDT

<rdar://problem/5305002>

Comment 4 Tim Horton 2015-08-16 02:03:18 PDT

Created attachment 259120 [details]
Patch

Comment 5 Simon Fraser (smfr) 2015-08-17 10:39:51 PDT

Comment on attachment 259120 [details]
Patch

We should add a way to test DocumentMarkers.

Comment 6 Tim Horton 2015-08-17 10:52:35 PDT

(In reply to comment #5)
> Comment on attachment 259120 [details]
> Patch
> 
> We should add a way to test DocumentMarkers.

There is apparently a mechanism in Internals, so I'm going to try to write a test before landing.

Comment 7 Tim Horton 2015-08-17 11:12:32 PDT

With a test!: http://trac.webkit.org/changeset/188527