Bug 148057

Summary: Add tests for computed method declarations with side effects
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: Tools / TestsAssignee: Ryosuke Niwa <rniwa>
Status: RESOLVED FIXED    
Severity: Normal CC: buildbot, commit-queue, fpizlo, ggaren, joepeck, mark.lam, msaboff, rniwa, saam
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 140491    
Attachments:
Description Flags
Adds test cases
none
Archive of layout-test-results from ews103 for mac-mavericks none

Ryosuke Niwa
Reported 2015-08-15 10:04:10 PDT
The expressions in computed properties can have a side effect. Test such side effects.
Attachments
Adds test cases (5.69 KB, patch)
2015-09-01 10:32 PDT, Ryosuke Niwa 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ews103 for mac-mavericks (614.18 KB, application/zip)
2015-09-01 11:05 PDT, Build Bot 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1 2015-09-01 10:32:33 PDT
Created attachment 260367 [details] Adds test cases
Ryosuke Niwa
Comment 2 2015-09-01 11:04:19 PDT
Comment on attachment 260367 [details] Adds test cases Thanks for the review!
Build Bot
Comment 3 2015-09-01 11:05:26 PDT
Comment on attachment 260367 [details] Adds test cases Attachment 260367 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/130374 New failing tests: http/tests/w3c/dom/nodes/ParentNode-querySelector-All.html
Build Bot
Comment 4 2015-09-01 11:05:29 PDT
Created attachment 260372 [details] Archive of layout-test-results from ews103 for mac-mavericks The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews103 Port: mac-mavericks Platform: Mac OS X 10.9.5
WebKit Commit Bot
Comment 5 2015-09-01 14:31:32 PDT
Comment on attachment 260367 [details] Adds test cases Clearing flags on attachment: 260367 Committed r189229: <http://trac.webkit.org/changeset/189229>
WebKit Commit Bot
Comment 6 2015-09-01 14:31:36 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.