Bug 148057

Summary: Add tests for computed method declarations with side effects
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: Tools / TestsAssignee: Ryosuke Niwa <rniwa>
Status: RESOLVED FIXED    
Severity: Normal CC: buildbot, commit-queue, fpizlo, ggaren, joepeck, mark.lam, msaboff, rniwa, saam
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 140491    
Attachments:
Description Flags
Adds test cases
none
Archive of layout-test-results from ews103 for mac-mavericks none

Description Ryosuke Niwa 2015-08-15 10:04:10 PDT 
The expressions in computed properties can have a side effect.
Test such side effects.
Comment 1 Ryosuke Niwa 2015-09-01 10:32:33 PDT 
Created attachment 260367 [details]
Adds test cases
Comment 2 Ryosuke Niwa 2015-09-01 11:04:19 PDT 
Comment on attachment 260367 [details]
Adds test cases

Thanks for the review!
Comment 3 Build Bot 2015-09-01 11:05:26 PDT 
Comment on attachment 260367 [details]
Adds test cases

Attachment 260367 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/130374

New failing tests:
http/tests/w3c/dom/nodes/ParentNode-querySelector-All.html
Comment 4 Build Bot 2015-09-01 11:05:29 PDT 
Created attachment 260372 [details]
Archive of layout-test-results from ews103 for mac-mavericks

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103  Port: mac-mavericks  Platform: Mac OS X 10.9.5
Comment 5 WebKit Commit Bot 2015-09-01 14:31:32 PDT 
Comment on attachment 260367 [details]
Adds test cases

Clearing flags on attachment: 260367

Committed r189229: <http://trac.webkit.org/changeset/189229>
Comment 6 WebKit Commit Bot 2015-09-01 14:31:36 PDT 
All reviewed patches have been landed.  Closing bug.