Bug 148057 - Add tests for computed method declarations with side effects
Summary: Add tests for computed method declarations with side effects
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryosuke Niwa
URL:
Keywords:
Depends on:
Blocks: 140491
  Show dependency treegraph
 
Reported: 2015-08-15 10:04 PDT by Ryosuke Niwa
Modified: 2015-09-01 14:31 PDT (History)
9 users (show)

See Also:


Attachments
Adds test cases (5.69 KB, patch)
2015-09-01 10:32 PDT, Ryosuke Niwa
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews103 for mac-mavericks (614.18 KB, application/zip)
2015-09-01 11:05 PDT, Build Bot
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2015-08-15 10:04:10 PDT
The expressions in computed properties can have a side effect.
Test such side effects.
Comment 1 Ryosuke Niwa 2015-09-01 10:32:33 PDT
Created attachment 260367 [details]
Adds test cases
Comment 2 Ryosuke Niwa 2015-09-01 11:04:19 PDT
Comment on attachment 260367 [details]
Adds test cases

Thanks for the review!
Comment 3 Build Bot 2015-09-01 11:05:26 PDT
Comment on attachment 260367 [details]
Adds test cases

Attachment 260367 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/130374

New failing tests:
http/tests/w3c/dom/nodes/ParentNode-querySelector-All.html
Comment 4 Build Bot 2015-09-01 11:05:29 PDT
Created attachment 260372 [details]
Archive of layout-test-results from ews103 for mac-mavericks

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103  Port: mac-mavericks  Platform: Mac OS X 10.9.5
Comment 5 WebKit Commit Bot 2015-09-01 14:31:32 PDT
Comment on attachment 260367 [details]
Adds test cases

Clearing flags on attachment: 260367

Committed r189229: <http://trac.webkit.org/changeset/189229>
Comment 6 WebKit Commit Bot 2015-09-01 14:31:36 PDT
All reviewed patches have been landed.  Closing bug.