Summary: | Remove a few includes from JSGlobalObject.h | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Simon Fraser (smfr) <simon.fraser> | ||||||
Component: | New Bugs | Assignee: | Geoffrey Garen <ggaren> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | commit-queue, fpizlo, ggaren, sam, simon.fraser | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Bug Depends on: | 148013 | ||||||||
Bug Blocks: | |||||||||
Attachments: |
|
Description
Simon Fraser (smfr)
2015-08-13 17:40:42 PDT
Created attachment 258961 [details]
Patch
Comment on attachment 258961 [details] Patch Clearing flags on attachment: 258961 Committed r188431: <http://trac.webkit.org/changeset/188431> All reviewed patches have been landed. Closing bug. Re-opened since this is blocked by bug 148013 Geoff/Filip: can someone help me land this? I wasn't able to figure out the right #includes to get Debug building. Here's where a build failed: https://build.webkit.org/builders/Apple%20Mavericks%20Debug%20%28Build%29/builds/19317/steps/compile-webkit/logs/stdio Looks like StructureRareDataInlines.h needs to #include JSString.h. Phil, anything useful here? Created attachment 262480 [details]
Patch
Comment on attachment 262480 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=262480&action=review r=me > Source/JavaScriptCore/runtime/JSGlobalObject.h:81 > +class NullGetterFunction; Duplicate > Source/JavaScriptCore/runtime/JSGlobalObject.h:83 > +class NullSetterFunction; Duplicate Committed r190601: <http://trac.webkit.org/changeset/190601> |