Bug 147986

Summary:

WTF should have a compact Condition object to use with Lock

Product:

WebKit

Reporter:

Filip Pizlo <fpizlo>

Component:

Web Template Framework

Assignee:

Filip Pizlo <fpizlo>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

barraclough, basile_clement, benjamin, commit-queue, ggaren, mark.lam, mhahnenb, mmirman, msaboff, nrotem, oliver, saam, sam

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Bug Depends on:

Bug Blocks:

147841

Attachments:

Description	Flags
the patch	ggaren: review+

Description Filip Pizlo 2015-08-13 12:49:46 PDT

Patch forthcoming.

Comment 1 Filip Pizlo 2015-08-13 13:15:52 PDT

Created attachment 258920 [details]
the patch

Comment 2 WebKit Commit Bot 2015-08-13 13:19:12 PDT

Attachment 258920 [details] did not pass style-queue:


ERROR: Source/WTF/wtf/ParkingLot.cpp:561:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Tools/TestWebKitAPI/Tests/WTF/Condition.cpp:101:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Tools/TestWebKitAPI/Tests/WTF/Condition.cpp:109:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Tools/TestWebKitAPI/Tests/WTF/Condition.cpp:136:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Tools/TestWebKitAPI/Tests/WTF/Condition.cpp:143:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Tools/TestWebKitAPI/Tests/WTF/Condition.cpp:250:  More than one command on the same line  [whitespace/newline] [4]
Total errors found: 6 in 14 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 3 Geoffrey Garen 2015-08-13 13:28:19 PDT

Comment on attachment 258920 [details]
the patch

r=me

Comment 4 Filip Pizlo 2015-08-13 13:42:51 PDT

Landed in http://trac.webkit.org/changeset/188400