Bug 147986 - WTF should have a compact Condition object to use with Lock
Summary: WTF should have a compact Condition object to use with Lock
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Template Framework (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Filip Pizlo
URL:
Keywords:
Depends on:
Blocks: 147841
  Show dependency treegraph
 
Reported: 2015-08-13 12:49 PDT by Filip Pizlo
Modified: 2015-08-13 13:42 PDT (History)
13 users (show)

See Also:


Attachments
the patch (33.02 KB, patch)
2015-08-13 13:15 PDT, Filip Pizlo
ggaren: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2015-08-13 12:49:46 PDT
Patch forthcoming.
Comment 1 Filip Pizlo 2015-08-13 13:15:52 PDT
Created attachment 258920 [details]
the patch
Comment 2 WebKit Commit Bot 2015-08-13 13:19:12 PDT
Attachment 258920 [details] did not pass style-queue:


ERROR: Source/WTF/wtf/ParkingLot.cpp:561:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Tools/TestWebKitAPI/Tests/WTF/Condition.cpp:101:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Tools/TestWebKitAPI/Tests/WTF/Condition.cpp:109:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Tools/TestWebKitAPI/Tests/WTF/Condition.cpp:136:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Tools/TestWebKitAPI/Tests/WTF/Condition.cpp:143:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Tools/TestWebKitAPI/Tests/WTF/Condition.cpp:250:  More than one command on the same line  [whitespace/newline] [4]
Total errors found: 6 in 14 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Geoffrey Garen 2015-08-13 13:28:19 PDT
Comment on attachment 258920 [details]
the patch

r=me
Comment 4 Filip Pizlo 2015-08-13 13:42:51 PDT
Landed in http://trac.webkit.org/changeset/188400