Bug 147982 – Remove pixelSnapped* functions from RenderBoxModelObject/RenderBox.

• Component: Layout and Rendering
• Status: RESOLVED FIXED

[alan]

They are highly misleading. (integral vs. device pixel snapping)

[alan]

Created attachment 258903 [details]
Patch

[Build Bot]

Comment on attachment 258903 [details]
Patch

Attachment 258903 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/53734

New failing tests:
fast/dom/HTMLImageElement/image-without-renderer-width.html
js/dom/custom-constructors.html

[Build Bot]

Created attachment 258909 [details]
Archive of layout-test-results from ews102 for mac-mavericks

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102  Port: mac-mavericks  Platform: Mac OS X 10.9.5

[Build Bot]

Comment on attachment 258903 [details]
Patch

Attachment 258903 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/53781

New failing tests:
fast/dom/HTMLImageElement/image-without-renderer-width.html
js/dom/custom-constructors.html

[Build Bot]

Created attachment 258913 [details]
Archive of layout-test-results from ews105 for mac-mavericks-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews105  Port: mac-mavericks-wk2  Platform: Mac OS X 10.9.5

[alan]

Created attachment 258914 [details]
Patch

[alan]

Created attachment 258921 [details]
Patch

[alan]

Created attachment 258926 [details]
Patch

[Simon Fraser (smfr)]

Comment on attachment 258926 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=258926&action=review

> Source/WebCore/html/shadow/SpinButtonElement.cpp:92
> +        if (box->borderBoxRect().contains(local)) {

In theory event handling should match painting, but in practice it doesn't matter.

> Source/WebCore/rendering/RenderBox.h:156
> +    virtual IntRect borderBoundingBox() const override final { return snappedIntRect(borderBoxRect()); }

Maybe put "snapped" in the name? Maybe remove this entirely.

[alan]

Created attachment 258972 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 258972 [details]
Patch

Clearing flags on attachment: 258972

Committed r188433: <http://trac.webkit.org/changeset/188433>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.