| Summary: | ScriptExecutionContext.h pulls in all the JSC headers | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Simon Fraser (smfr) <simon.fraser> | ||||||||
| Component: | New Bugs | Assignee: | Simon Fraser (smfr) <simon.fraser> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | bfulgham, commit-queue, dino, esprehn+autocc, gyuyoung.kim, kangil.han, kondapallykalyan, roger_fong, simon.fraser | ||||||||
| Priority: | P2 | ||||||||||
| Version: | 528+ (Nightly build) | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Bug Depends on: | |||||||||||
| Bug Blocks: | 147967 | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Simon Fraser (smfr)
2015-08-12 22:32:59 PDT
Created attachment 258877 [details]
Patch
Created attachment 258878 [details]
RenderBlock.d diff with the change
Looks like some of the *Inlines.h headers need to be re-added to .cpp files. Hmm this built for me locally, in Debug. Yes, that's expected I think - in Debug, inlines are not inlined, so the linker has a copy to use that was generated in some other compilation unit. Created attachment 258893 [details]
Patch
Comment on attachment 258893 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=258893&action=review > Source/WebCore/Modules/webdatabase/SQLTransaction.h:33 > +#include "EventTarget.h" > #include "SQLCallbackWrapper.h" Out of order This broke the Windows build. :-( |