Bug 147969

Summary: ScriptExecutionContext.h pulls in all the JSC headers
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: New BugsAssignee: Simon Fraser (smfr) <simon.fraser>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, commit-queue, dino, esprehn+autocc, gyuyoung.kim, kangil.han, kondapallykalyan, roger_fong, simon.fraser
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 147967    
Attachments:
Description Flags
Patch
none
RenderBlock.d diff with the change
none
Patch ap: review+

Simon Fraser (smfr)
Reported 2015-08-12 22:32:59 PDT
ScriptExecutionContext.h pulls in all the JSC headers
Attachments
Patch (4.81 KB, patch)
2015-08-12 22:34 PDT, Simon Fraser (smfr) 		no flags
DetailsFormatted DiffDiff
RenderBlock.d diff with the change (44.32 KB, text/plain)
2015-08-12 22:35 PDT, Simon Fraser (smfr) 		no flags
Details
Patch (5.37 KB, patch)
2015-08-13 09:53 PDT, Simon Fraser (smfr) 		ap: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1 2015-08-12 22:34:58 PDT
Created attachment 258877 [details] Patch
Simon Fraser (smfr)
Comment 2 2015-08-12 22:35:56 PDT
Created attachment 258878 [details] RenderBlock.d diff with the change
Alexey Proskuryakov
Comment 3 2015-08-12 23:13:20 PDT
Looks like some of the *Inlines.h headers need to be re-added to .cpp files.
Simon Fraser (smfr)
Comment 4 2015-08-12 23:18:09 PDT
Hmm this built for me locally, in Debug.
Alexey Proskuryakov
Comment 5 2015-08-13 00:01:46 PDT
Yes, that's expected I think - in Debug, inlines are not inlined, so the linker has a copy to use that was generated in some other compilation unit.
Simon Fraser (smfr)
Comment 6 2015-08-13 09:53:41 PDT
Created attachment 258893 [details] Patch
Alexey Proskuryakov
Comment 7 2015-08-13 11:28:31 PDT
Comment on attachment 258893 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=258893&action=review > Source/WebCore/Modules/webdatabase/SQLTransaction.h:33 > +#include "EventTarget.h" > #include "SQLCallbackWrapper.h" Out of order
Brent Fulgham
Comment 8 2015-08-13 12:28:53 PDT
This broke the Windows build. :-(
Simon Fraser (smfr)
Comment 9 2015-08-13 18:12:45 PDT
http://trac.webkit.org/changeset/188388
Note You need to log in before you can comment on or make changes to this bug.