Bug 147943

Summary: [ES6] Implement Reflect.defineProperty
Product: WebKit Reporter: Yusuke Suzuki <ysuzuki>
Component: New BugsAssignee: Yusuke Suzuki <ysuzuki>
Status: RESOLVED FIXED    
Severity: Normal CC: darin, ggaren, saam, sam
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch saam: review+

Description Yusuke Suzuki 2015-08-12 11:36:38 PDT
[ES6] Implement Reflect.defineProperty
Comment 1 Yusuke Suzuki 2015-08-12 11:38:34 PDT
Created attachment 258832 [details]
Patch
Comment 2 Saam Barati 2015-08-12 14:00:45 PDT
Comment on attachment 258832 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=258832&action=review

r=me

> Source/JavaScriptCore/runtime/ReflectObject.cpp:88
> +EncodedJSValue JSC_HOST_CALL reflectObjectDefineProperty(ExecState* exec)

A link to the spec here would be nice.
Comment 3 Yusuke Suzuki 2015-08-12 15:25:15 PDT
Comment on attachment 258832 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=258832&action=review

Thank you for your review :)

>> Source/JavaScriptCore/runtime/ReflectObject.cpp:88
>> +EncodedJSValue JSC_HOST_CALL reflectObjectDefineProperty(ExecState* exec)
> 
> A link to the spec here would be nice.

Sounds nice! I'll add it here.
Comment 4 Yusuke Suzuki 2015-08-12 15:59:25 PDT
Committed r188361: <http://trac.webkit.org/changeset/188361>