Bug 147941

Summary: CachedResource leak in validation code
Product: WebKit Reporter: Antti Koivisto <koivisto>
Component: Page LoadingAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, cdumez, commit-queue, japhet
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch none

Antti Koivisto
Reported 2015-08-12 11:33:22 PDT
While adding test coverage I discovered a way to hit ASSERT(!resource->m_proxyResource) in CachedResource::setResourceToRevalidate. I think this ends up leaking a resource.
Attachments
patch (9.15 KB, patch)
2015-08-12 11:44 PDT, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Antti Koivisto
Comment 1 2015-08-12 11:44:33 PDT
Created attachment 258833 [details] patch
Chris Dumez
Comment 2 2015-08-12 11:57:07 PDT
Comment on attachment 258833 [details] patch r=me, nice find!
WebKit Commit Bot
Comment 3 2015-08-12 14:08:11 PDT
Comment on attachment 258833 [details] patch Clearing flags on attachment: 258833 Committed r188358: <http://trac.webkit.org/changeset/188358>
WebKit Commit Bot
Comment 4 2015-08-12 14:08:16 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.