Bug 147941

Summary:

CachedResource leak in validation code

Product:

WebKit

Reporter:

Antti Koivisto <koivisto>

Component:

Page Loading

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ap, cdumez, commit-queue, japhet

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
patch	none

Description Antti Koivisto 2015-08-12 11:33:22 PDT

While adding test coverage I discovered a way to hit ASSERT(!resource->m_proxyResource) in CachedResource::setResourceToRevalidate. I think this ends up leaking a resource.

Comment 1 Antti Koivisto 2015-08-12 11:44:33 PDT

Created attachment 258833 [details]
patch

Comment 2 Chris Dumez 2015-08-12 11:57:07 PDT

Comment on attachment 258833 [details]
patch

r=me, nice find!

Comment 3 WebKit Commit Bot 2015-08-12 14:08:11 PDT

Comment on attachment 258833 [details]
patch

Clearing flags on attachment: 258833

Committed r188358: <http://trac.webkit.org/changeset/188358>

Comment 4 WebKit Commit Bot 2015-08-12 14:08:16 PDT

All reviewed patches have been landed.  Closing bug.