Bug 147941 - CachedResource leak in validation code
Summary: CachedResource leak in validation code
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Page Loading (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-08-12 11:33 PDT by Antti Koivisto
Modified: 2015-08-12 14:08 PDT (History)
4 users (show)

See Also:

Attachments
patch (9.15 KB, patch)
2015-08-12 11:44 PDT, Antti Koivisto 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Antti Koivisto 2015-08-12 11:33:22 PDT 
While adding test coverage I discovered a way to hit ASSERT(!resource->m_proxyResource) in CachedResource::setResourceToRevalidate. I think this ends up leaking a resource.
Comment 1 Antti Koivisto 2015-08-12 11:44:33 PDT 
Created attachment 258833 [details]
patch
Comment 2 Chris Dumez 2015-08-12 11:57:07 PDT 
Comment on attachment 258833 [details]
patch

r=me, nice find!
Comment 3 WebKit Commit Bot 2015-08-12 14:08:11 PDT 
Comment on attachment 258833 [details]
patch

Clearing flags on attachment: 258833

Committed r188358: <http://trac.webkit.org/changeset/188358>
Comment 4 WebKit Commit Bot 2015-08-12 14:08:16 PDT 
All reviewed patches have been landed.  Closing bug.