Bug 147924

Summary:

Web Inspector: Can't resize split console when window is too narrow

Product:

WebKit

Reporter:

Nikita Vasilyev <nvasilyev>

Component:

Web Inspector

Assignee:

Nikita Vasilyev <nvasilyev>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bburg, commit-queue, graouts, joepeck, mattbaker, nvasilyev, timothy, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Animated GIF of the problem	none
Patch	timothy: review+
[Image] Red - draggable area	none
Patch	none
Patch	none

Nikita Vasilyev

Reported 2015-08-11 23:25:26 PDT

Created attachment 258808 [details] Animated GIF of the problem 1. 4 pixels at the top of the split console show allow to resize it. 2. When hovering over the resizer, the empty area between the "Console" label and the "Filter Console Log" search field, mouse cursor should change to up-down arrow (⬍). 3. "Filter Console Log" placeholder text shouldn't be selectable.

Attachments
Animated GIF of the problem (478.82 KB, image/gif) 2015-08-11 23:25 PDT, Nikita Vasilyev	no flags	Details
Patch (1.56 KB, patch) 2015-08-13 21:35 PDT, Nikita Vasilyev	timothy: review+	Details Formatted Diff Diff
[Image] Red - draggable area (32.07 KB, image/png) 2015-08-13 21:39 PDT, Nikita Vasilyev	no flags	Details
Patch (1.57 KB, patch) 2015-08-13 22:26 PDT, Nikita Vasilyev	no flags	Details Formatted Diff Diff
Patch (1.57 KB, patch) 2015-08-13 22:27 PDT, Nikita Vasilyev	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Timothy Hatcher

Comment 1 2015-08-11 23:58:05 PDT

Because resizing is on;y allowed on FlexibleSpaceNavigationItems and empty space in the navigation bar. We should fix this.

Nikita Vasilyev

Comment 2 2015-08-13 21:35:07 PDT

Created attachment 258974 [details] Patch

Radar WebKit Bug Importer

Comment 3 2015-08-13 21:35:23 PDT

<rdar://problem/22282417>

Nikita Vasilyev

Comment 4 2015-08-13 21:39:20 PDT

Created attachment 258977 [details] [Image] Red - draggable area

Timothy Hatcher

Comment 5 2015-08-13 22:13:32 PDT

Comment on attachment 258974 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=258974&action=review > Source/WebInspectorUI/UserInterface/Views/Main.css:177 > +#split-content-browser > .navigation-bar .log-scope-bar { :matches() > Source/WebInspectorUI/UserInterface/Views/Main.css:182 > +#split-content-browser > .navigation-bar .log-scope-bar > li { Ditto.

Nikita Vasilyev

Comment 6 2015-08-13 22:26:42 PDT

Created attachment 258980 [details] Patch

Nikita Vasilyev

Comment 7 2015-08-13 22:27:59 PDT

Created attachment 258981 [details] Patch

WebKit Commit Bot

Comment 8 2015-08-13 23:21:26 PDT

Comment on attachment 258981 [details] Patch Clearing flags on attachment: 258981 Committed r188442: <http://trac.webkit.org/changeset/188442>

WebKit Commit Bot

Comment 9 2015-08-13 23:21:31 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.