Bug 147921

Summary: CSSParserValueList argument should be a reference
Product: WebKit Reporter: Gyuyoung Kim <gyuyoung.kim>
Component: CSSAssignee: Gyuyoung Kim <gyuyoung.kim>
Status: RESOLVED WONTFIX    
Severity: Normal CC: ahmad.saleem792, ap, dbates, rniwa, simon.fraser, zalan
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch bfulgham: review+

Gyuyoung Kim
Reported 2015-08-11 21:38:41 PDT
Argument of CSSParserValueList has been treated as it is non-null pointer. So it should be a reference.
Attachments
Patch (6.71 KB, patch)
2015-08-11 21:39 PDT, Gyuyoung Kim 		no flags
DetailsFormatted DiffDiff
Patch (6.66 KB, patch)
2015-08-11 21:42 PDT, Gyuyoung Kim 		bfulgham: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Gyuyoung Kim
Comment 1 2015-08-11 21:39:41 PDT
Created attachment 258800 [details] Patch
Gyuyoung Kim
Comment 2 2015-08-11 21:42:10 PDT
Created attachment 258801 [details] Patch
Brent Fulgham
Comment 3 2015-08-13 08:52:50 PDT
Comment on attachment 258801 [details] Patch r=me
Ahmad Saleem
Comment 4 2022-07-24 10:55:12 PDT
@bfulgham@webkit.org - it is r+ patch, has this landed or it got changed or fixed. There is no test case in the attached patch, which I can use to test it. Appreciate if you can update it accordingly as you needed. Thanks!
Ryosuke Niwa
Comment 5 2022-07-24 13:51:02 PDT
This is a change for old CSS parser. I'm pretty sure the patch is no longer relevant.
Note You need to log in before you can comment on or make changes to this bug.