Bug 147921

Summary: CSSParserValueList argument should be a reference
Product: WebKit Reporter: Gyuyoung Kim <gyuyoung.kim>
Component: CSSAssignee: Gyuyoung Kim <gyuyoung.kim>
Status: RESOLVED WONTFIX    
Severity: Normal CC: ahmad.saleem792, ap, dbates, rniwa, simon.fraser, zalan
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch bfulgham: review+

Description Gyuyoung Kim 2015-08-11 21:38:41 PDT 
Argument of CSSParserValueList has been treated as it is non-null pointer. So it should be a reference.
Comment 1 Gyuyoung Kim 2015-08-11 21:39:41 PDT 
Created attachment 258800 [details]
Patch
Comment 2 Gyuyoung Kim 2015-08-11 21:42:10 PDT 
Created attachment 258801 [details]
Patch
Comment 3 Brent Fulgham 2015-08-13 08:52:50 PDT 
Comment on attachment 258801 [details]
Patch

r=me
Comment 4 Ahmad Saleem 2022-07-24 10:55:12 PDT 
@bfulgham@webkit.org - it is r+ patch, has this landed or it got changed or fixed. There is no test case in the attached patch, which I can use to test it. Appreciate if you can update it accordingly as you needed. Thanks!
Comment 5 Ryosuke Niwa 2022-07-24 13:51:02 PDT 
This is a change for old CSS parser. I'm pretty sure the patch is no longer relevant.