Bug 147920

Summary: [OS X] Remove support for composite fonts
Product: WebKit Reporter: Myles C. Maxfield <mmaxfield>
Component: New BugsAssignee: Myles C. Maxfield <mmaxfield>
Status: RESOLVED FIXED    
Severity: Normal CC: mitz
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch mitz: review+

Myles C. Maxfield
Reported 2015-08-11 19:32:36 PDT
[OS X] Remove support for composite fonts
Attachments
Patch (242.68 KB, patch)
2015-08-11 19:36 PDT, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
Patch (242.59 KB, patch)
2015-08-11 19:41 PDT, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
Patch (243.11 KB, patch)
2015-08-17 17:13 PDT, Myles C. Maxfield 		mitz: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Myles C. Maxfield
Comment 1 2015-08-11 19:36:10 PDT
Created attachment 258795 [details] Patch
Myles C. Maxfield
Comment 2 2015-08-11 19:41:02 PDT
Created attachment 258796 [details] Patch
Myles C. Maxfield
Comment 3 2015-08-17 17:13:54 PDT
Created attachment 259213 [details] Patch
mitz
Comment 4 2015-08-17 18:30:29 PDT
Comment on attachment 259213 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=259213&action=review > Source/WebCore/ChangeLog:13 > + CTRunGetStringIndices() to map from the code points to the glyphs. This approach is > + fundamentally incorrect, as it will combine consecutive code points together in the > + string if possible to produce a glyph. “Fundamentally incorrect” is not a good characterization of the approach. A more accurate statement would be that the implementation of this approach is currently buggy in that it relies on getCFStringAttributes() to return attributes that turn off essential ligatures, but it has become possible for it to be used in cases where getCFStringAttributes() return attributes that do not turn off essential ligatures. Anyway, I think this preamble is unnecessary. > Source/WebCore/ChangeLog:15 > + The only way WebKit will ever trigger this code path is if we are inspecting a “inspecting”?
Myles C. Maxfield
Comment 5 2015-08-17 19:08:05 PDT
Committed r188566: <http://trac.webkit.org/changeset/188566>
Myles C. Maxfield
Comment 6 2015-08-17 21:27:38 PDT
Follow up patch http://trac.webkit.org/changeset/188569
Myles C. Maxfield
Comment 7 2015-08-17 21:55:57 PDT
*** Bug 147859 has been marked as a duplicate of this bug. ***
Note You need to log in before you can comment on or make changes to this bug.