| Summary: | [OS X] Remove support for composite fonts | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Myles C. Maxfield <mmaxfield> | ||||||||
| Component: | New Bugs | Assignee: | Myles C. Maxfield <mmaxfield> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | mitz | ||||||||
| Priority: | P2 | ||||||||||
| Version: | 528+ (Nightly build) | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Myles C. Maxfield
2015-08-11 19:32:36 PDT
Created attachment 258795 [details]
Patch
Created attachment 258796 [details]
Patch
Created attachment 259213 [details]
Patch
Comment on attachment 259213 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=259213&action=review > Source/WebCore/ChangeLog:13 > + CTRunGetStringIndices() to map from the code points to the glyphs. This approach is > + fundamentally incorrect, as it will combine consecutive code points together in the > + string if possible to produce a glyph. “Fundamentally incorrect” is not a good characterization of the approach. A more accurate statement would be that the implementation of this approach is currently buggy in that it relies on getCFStringAttributes() to return attributes that turn off essential ligatures, but it has become possible for it to be used in cases where getCFStringAttributes() return attributes that do not turn off essential ligatures. Anyway, I think this preamble is unnecessary. > Source/WebCore/ChangeLog:15 > + The only way WebKit will ever trigger this code path is if we are inspecting a “inspecting”? Committed r188566: <http://trac.webkit.org/changeset/188566> Follow up patch http://trac.webkit.org/changeset/188569 *** Bug 147859 has been marked as a duplicate of this bug. *** |