Bug 147888

Summary:

Remove UnspecifiedBoolType from WTF

Product:

WebKit

Reporter:

Keith Miller <keith_miller>

Component:

Web Template Framework

Assignee:

Nobody <webkit-unassigned>

Status:

NEW ---

Severity:

Normal

CC:

commit-queue, ggaren, krollin

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	ggaren: review-
Patch	ggaren: review+, commit-queue: commit-queue-

Description Keith Miller 2015-08-11 11:43:08 PDT

We still use the safe bool idiom (UnspecifiedBoolType) from pre C++11 in WTF. We should replace the safe bool idiom with explicit bool() instead.

Comment 1 Keith Miller 2015-08-11 11:55:19 PDT

Created attachment 258732 [details]
Patch

Comment 2 Keith Miller 2015-08-17 20:24:04 PDT

Created attachment 259227 [details]
Patch

rebased so it should, hopefully, apply.

Comment 3 WebKit Commit Bot 2015-08-17 20:25:55 PDT

Attachment 259227 [details] did not pass style-queue:


ERROR: Source/WTF/wtf/RetainPtr.h:31:  Streams are highly discouraged.  [readability/streams] [3]
Total errors found: 1 in 66 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 4 Geoffrey Garen 2015-08-18 10:16:57 PDT

Comment on attachment 259227 [details]
Patch

EWS still angry

Comment 5 Keith Miller 2015-08-18 15:26:52 PDT

Created attachment 259304 [details]
Patch

Let's try this again...

Comment 6 Geoffrey Garen 2015-08-18 15:51:45 PDT

Comment on attachment 259304 [details]
Patch

I shed a single tear over all this !! nonsense. I do not not dislike it.

Comment 7 WebKit Commit Bot 2015-08-18 16:45:33 PDT

Comment on attachment 259304 [details]
Patch

Rejecting attachment 259304 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'build', '--no-clean', '--no-update', '--build-style=release', '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
a -c /Volumes/Data/EWS/WebKit/Source/WebCore/loader/archive/ArchiveResource.cpp -o /Volumes/Data/EWS/WebKit/WebKitBuild/WebCore.build/Release/WebCore.build/Objects-normal/x86_64/ArchiveResource.o

** BUILD FAILED **


The following build commands failed:
	CompileC /Volumes/Data/EWS/WebKit/WebKitBuild/WebCore.build/Release/WebCore.build/Objects-normal/x86_64/ApplicationCacheGroup.o loader/appcache/ApplicationCacheGroup.cpp normal x86_64 c++ com.apple.compilers.llvm.clang.1_0.compiler
(1 failure)

Full output: http://webkit-queues.webkit.org/results/73245

Comment 8 Keith Rollin 2017-01-30 17:25:21 PST

What's the status of this bug? Did Geoff scare off Keith?

I saw the use of UnspecifiedBoolType in the sources and thought I'd get rid of it. But first I checked to see if there was any reason recorded for not not keeping it. That brought me to this bug. Is there any reason to not not not move forward with it?