Summary: | [ES6] Implement computed accessors | ||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Geoffrey Garen <ggaren> | ||||||||||||||
Component: | JavaScriptCore | Assignee: | Yusuke Suzuki <ysuzuki> | ||||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||||
Severity: | Normal | CC: | buildbot, commit-queue, fpizlo, ggaren, joepeck, mark.lam, mmirman, rniwa, saam, ysuzuki | ||||||||||||||
Priority: | P2 | ||||||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||||||
Hardware: | Unspecified | ||||||||||||||||
OS: | Unspecified | ||||||||||||||||
Bug Depends on: | |||||||||||||||||
Bug Blocks: | 148860 | ||||||||||||||||
Attachments: |
|
Description
Geoffrey Garen
2015-08-11 10:59:41 PDT
Created attachment 259029 [details]
Parsing Patch
Comment on attachment 259029 [details]
Parsing Patch
Do any of these tests cover actually loading or storing to the accessor property?
Comment on attachment 259029 [details] Parsing Patch This patch doesn't handle interactions with non-accessor properties of the same name. e.g. var foo = 'a'; {a: 1, get [foo]() {}} {get [foo]() {}, a: 1} See http://trac.webkit.org/changeset/184324 which addressed this problem for accessors with regular name. We probably need to add new op codes to add accessors by value. (In reply to comment #4) > Also see https://bugs.webkit.org/show_bug.cgi?id=142690. (In reply to comment #2) > Comment on attachment 259029 [details] > Parsing Patch > > Do any of these tests cover actually loading or storing to the accessor > property? As suggested by ggaren, this patch only addresses parsing and will still fail if the code is run. Created attachment 259042 [details] Parsing Patch Adds support for classes. Some overlap with https://bugs.webkit.org/show_bug.cgi?id=142690 will need to pull before submitting. Comment on attachment 259042 [details] Parsing Patch View in context: https://bugs.webkit.org/attachment.cgi?id=259042&action=review > Source/JavaScriptCore/ChangeLog:4 > + Implements parsing for computed accessor properties on getters and setters. > + https://bugs.webkit.org/show_bug.cgi?id=147883 Can we file a new WebKit bug that blocks this bug and post this patch there? This bug is about implementing the full feature. Comment on attachment 259042 [details] Parsing Patch Attachment 259042 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/59403 New failing tests: js/parser-syntax-check.html Created attachment 259048 [details]
Archive of layout-test-results from ews103 for mac-mavericks
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103 Port: mac-mavericks Platform: Mac OS X 10.9.5
Comment on attachment 259042 [details] Parsing Patch Attachment 259042 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/59400 New failing tests: js/parser-syntax-check.html Created attachment 259049 [details]
Archive of layout-test-results from ews106 for mac-mavericks-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106 Port: mac-mavericks-wk2 Platform: Mac OS X 10.9.5
I'll extract Matthew's parsing patch to the separated issue. Created attachment 260661 [details]
Patch
WIP: not tested yet
Since the executing part does not become so large, I'll attempt to implement parsing & executing part in the one patch in this bug. Created attachment 260772 [details]
Patch
Comment on attachment 260772 [details]
Patch
r=me
Comment on attachment 260772 [details] Patch Clearing flags on attachment: 260772 Committed r189504: <http://trac.webkit.org/changeset/189504> All reviewed patches have been landed. Closing bug. |