Bug 142690 - ES6 class syntax should allow computed name method
Summary: ES6 class syntax should allow computed name method
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryosuke Niwa
URL:
Keywords:
Depends on:
Blocks: 140491
  Show dependency tree / graph
 
Reported: 2015-03-13 23:59 PDT by Ryosuke Niwa
Modified: 2015-08-14 16:50 PDT (History)
8 users (show)

See Also:

Attachments
Fixes the bug (21.37 KB, patch)
2015-03-14 00:06 PDT, Ryosuke Niwa 		no flags Details | Formatted Diff | Diff
Updated for ToT (21.34 KB, patch)
2015-03-16 22:16 PDT, Ryosuke Niwa 		no flags Details | Formatted Diff | Diff
Updated for ToT again (21.23 KB, patch)
2015-03-16 23:06 PDT, Ryosuke Niwa 		no flags Details | Formatted Diff | Diff
Fixes the bug (7.46 KB, patch)
2015-03-31 13:55 PDT, Ryosuke Niwa 		no flags Details | Formatted Diff | Diff
Adds the support (59.30 KB, patch)
2015-08-13 22:54 PDT, Ryosuke Niwa 		no flags Details | Formatted Diff | Diff
Updated for ToT (59.28 KB, patch)
2015-08-14 12:40 PDT, Ryosuke Niwa 		no flags Details | Formatted Diff | Diff
Fixed 32-bit build (61.65 KB, patch)
2015-08-14 13:39 PDT, Ryosuke Niwa 		no flags Details | Formatted Diff | Diff
Show Obsolete (6) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2015-03-13 23:59:34 PDT 
Adopt Joe's computed property goodness in ES6 class syntax.
Comment 1 Ryosuke Niwa 2015-03-14 00:06:38 PDT 
Created attachment 248641 [details]
Fixes the bug
Comment 2 Ryosuke Niwa 2015-03-16 22:16:51 PDT 
Created attachment 248819 [details]
Updated for ToT
Comment 3 Ryosuke Niwa 2015-03-16 23:06:36 PDT 
Created attachment 248828 [details]
Updated for ToT again
Comment 4 Ryosuke Niwa 2015-03-27 23:03:05 PDT 
Comment on attachment 248828 [details]
Updated for ToT again

This no longer applies on ToT.
Comment 5 Ryosuke Niwa 2015-03-31 13:55:17 PDT 
Created attachment 249848 [details]
Fixes the bug
Comment 6 Ryosuke Niwa 2015-03-31 13:55:53 PDT 
Comment on attachment 249848 [details]
Fixes the bug

Wrong bug.
Comment 7 Ryosuke Niwa 2015-08-13 22:54:12 PDT 
Created attachment 258984 [details]
Adds the support
Comment 8 Ryosuke Niwa 2015-08-14 12:40:34 PDT 
Created attachment 259027 [details]
Updated for ToT
Comment 9 Ryosuke Niwa 2015-08-14 13:39:28 PDT 
Created attachment 259032 [details]
Fixed 32-bit build
Comment 10 Saam Barati 2015-08-14 16:48:50 PDT 
Comment on attachment 259032 [details]
Fixed 32-bit build

r=me
I think it'd be good to have tests for computed method names that have side effects and we should assert that we do things in the correct order:
"[(x = 20, "foo")] {..}, [assert(x === 20), "bar"] {...}".
Ryosuke says he will open up another bug for this.
Comment 11 Ryosuke Niwa 2015-08-14 16:50:46 PDT 
Comment on attachment 259032 [details]
Fixed 32-bit build

Clearing flags on attachment: 259032

Committed r188498: <http://trac.webkit.org/changeset/188498>
Comment 12 Ryosuke Niwa 2015-08-14 16:50:52 PDT 
All reviewed patches have been landed.  Closing bug.