Bug 147842

Summary: HTMLMediaElement needs way to find MediaDeviceInfo keys
Product: WebKit Reporter: Matthew Daiter <mdaiter>
Component: WebCore Misc.Assignee: Matthew Daiter <mdaiter>
Status: RESOLVED FIXED    
Severity: Normal CC: beidson, bfulgham, commit-queue, eric.carlson, jer.noble, jonlee, mdaiter, webkit-bug-importer, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Description Matthew Daiter 2015-08-10 14:29:57 PDT 
Needed way for the HTMLMediaElement to find the MediaDeviceInfo keys. Must have this known so that the player can grab the keys and use them for interpreting the unique ids on the system.
Comment 1 Matthew Daiter 2015-08-10 14:32:07 PDT 
Created attachment 258651 [details]
Patch
Comment 2 Matthew Daiter 2015-08-10 14:41:58 PDT 
Created attachment 258653 [details]
Patch
Comment 3 Jer Noble 2015-08-10 15:01:10 PDT 
Comment on attachment 258653 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=258653&action=review

> Source/WebCore/page/Settings.h:275
> +    void setMediaDeviceInformationKeysStorageDirectory(const String& directory) { m_mediaDeviceInformationKeysStorageDirectory = directory; }
> +    const String& mediaDeviceInformationKeysStorageDirectory() const { return m_mediaDeviceInformationKeysStorageDirectory; }

Are you storing "media device information keys"? Or are you storing "media device identifiers"?  I'd argue it's the latter, which would make this "mediaDeviceIdentifierStorageDirectory()"
Comment 4 Matthew Daiter 2015-08-10 15:16:18 PDT 
Created attachment 258657 [details]
Patch
Comment 5 Matthew Daiter 2015-08-10 15:16:48 PDT 
Comment on attachment 258653 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=258653&action=review

>> Source/WebCore/page/Settings.h:275
>> +    const String& mediaDeviceInformationKeysStorageDirectory() const { return m_mediaDeviceInformationKeysStorageDirectory; }
> 
> Are you storing "media device information keys"? Or are you storing "media device identifiers"?  I'd argue it's the latter, which would make this "mediaDeviceIdentifierStorageDirectory()"

Fixed!
Comment 6 WebKit Commit Bot 2015-08-10 16:28:14 PDT 
Comment on attachment 258657 [details]
Patch

Clearing flags on attachment: 258657

Committed r188234: <http://trac.webkit.org/changeset/188234>
Comment 7 WebKit Commit Bot 2015-08-10 16:28:17 PDT 
All reviewed patches have been landed.  Closing bug.