Bug 147842

Summary: HTMLMediaElement needs way to find MediaDeviceInfo keys
Product: WebKit Reporter: Matthew Daiter <mdaiter>
Component: WebCore Misc.Assignee: Matthew Daiter <mdaiter>
Status: RESOLVED FIXED    
Severity: Normal CC: beidson, bfulgham, commit-queue, eric.carlson, jer.noble, jonlee, mdaiter, webkit-bug-importer, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Matthew Daiter
Reported 2015-08-10 14:29:57 PDT
Needed way for the HTMLMediaElement to find the MediaDeviceInfo keys. Must have this known so that the player can grab the keys and use them for interpreting the unique ids on the system.
Attachments
Patch (4.71 KB, patch)
2015-08-10 14:32 PDT, Matthew Daiter 		no flags
DetailsFormatted DiffDiff
Patch (4.67 KB, patch)
2015-08-10 14:41 PDT, Matthew Daiter 		no flags
DetailsFormatted DiffDiff
Patch (4.60 KB, patch)
2015-08-10 15:16 PDT, Matthew Daiter 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Matthew Daiter
Comment 1 2015-08-10 14:32:07 PDT
Created attachment 258651 [details] Patch
Matthew Daiter
Comment 2 2015-08-10 14:41:58 PDT
Created attachment 258653 [details] Patch
Jer Noble
Comment 3 2015-08-10 15:01:10 PDT
Comment on attachment 258653 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=258653&action=review > Source/WebCore/page/Settings.h:275 > + void setMediaDeviceInformationKeysStorageDirectory(const String& directory) { m_mediaDeviceInformationKeysStorageDirectory = directory; } > + const String& mediaDeviceInformationKeysStorageDirectory() const { return m_mediaDeviceInformationKeysStorageDirectory; } Are you storing "media device information keys"? Or are you storing "media device identifiers"? I'd argue it's the latter, which would make this "mediaDeviceIdentifierStorageDirectory()"
Matthew Daiter
Comment 4 2015-08-10 15:16:18 PDT
Created attachment 258657 [details] Patch
Matthew Daiter
Comment 5 2015-08-10 15:16:48 PDT
Comment on attachment 258653 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=258653&action=review >> Source/WebCore/page/Settings.h:275 >> + const String& mediaDeviceInformationKeysStorageDirectory() const { return m_mediaDeviceInformationKeysStorageDirectory; } > > Are you storing "media device information keys"? Or are you storing "media device identifiers"? I'd argue it's the latter, which would make this "mediaDeviceIdentifierStorageDirectory()" Fixed!
WebKit Commit Bot
Comment 6 2015-08-10 16:28:14 PDT
Comment on attachment 258657 [details] Patch Clearing flags on attachment: 258657 Committed r188234: <http://trac.webkit.org/changeset/188234>
WebKit Commit Bot
Comment 7 2015-08-10 16:28:17 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.