Bug 147833

Summary: Implement MediaDeviceIdentifierStorageDirectory
Product: WebKit Reporter: Matthew Daiter <mdaiter>
Component: WebKit2Assignee: Eric Carlson <eric.carlson>
Status: RESOLVED INVALID    
Severity: Normal CC: beidson, bfulgham, eric.carlson, jer.noble, jonlee, mdaiter, webkit-bug-importer, webkit.review.bot
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 147852    
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Rebased patch
none
Updated patch
none
Updated patch none

Description Matthew Daiter 2015-08-10 11:41:41 PDT
Needed to create a legacy storage directory for placing MediaDeviceIdentifierKeys
Comment 1 Matthew Daiter 2015-08-10 12:05:03 PDT
Created attachment 258631 [details]
Patch
Comment 2 Matthew Daiter 2015-08-10 13:34:47 PDT
Created attachment 258648 [details]
Patch
Comment 3 Matthew Daiter 2015-08-10 15:46:57 PDT
Created attachment 258660 [details]
Patch
Comment 4 Eric Carlson 2015-11-09 09:37:14 PST
Created attachment 265063 [details]
Rebased patch
Comment 5 Radar WebKit Bug Importer 2015-11-09 09:43:50 PST
<rdar://problem/23463882>
Comment 6 Darin Adler 2015-11-09 09:45:40 PST
Comment on attachment 265063 [details]
Rebased patch

View in context: https://bugs.webkit.org/attachment.cgi?id=265063&action=review

> Source/WebKit2/UIProcess/API/APIProcessPoolConfiguration.cpp:57
> -
> +    

Please don’t make this whitespace change.

> Source/WebKit2/UIProcess/API/APIProcessPoolConfiguration.h:89
> +    const WTF::String& mediaDeviceIdentifierStorageDirectory() const { return m_mediaDeviceIdentifierStorageDirectory; }
> +    void setMediaDeviceIdentifierStorageDirectory(const WTF::String& mediaDeviceIdentifierStorageDirectory) { m_mediaDeviceIdentifierStorageDirectory = mediaDeviceIdentifierStorageDirectory; }

Not sure why this file calls it WTF::String instead of String.

> Source/WebKit2/UIProcess/API/APIWebsiteDataStore.cpp:116
> +    // FIXME: Implement

Normally it’s a period at the end of each of these.

I don’t understand the status of these functions. Do these really need to be implemented? Or should this be oure virtual instead. Seems a little bit mysterious what the plan is for non-Cocoa, non-GTK platforms. I don’t think our platform independence strategy here is very good.
Comment 7 Eric Carlson 2015-11-09 10:36:08 PST
Comment on attachment 265063 [details]
Rebased patch

View in context: https://bugs.webkit.org/attachment.cgi?id=265063&action=review

>> Source/WebKit2/UIProcess/API/APIProcessPoolConfiguration.cpp:57
>> +    
> 
> Please don’t make this whitespace change.

Fixed.

>> Source/WebKit2/UIProcess/API/APIProcessPoolConfiguration.h:89
>> +    void setMediaDeviceIdentifierStorageDirectory(const WTF::String& mediaDeviceIdentifierStorageDirectory) { m_mediaDeviceIdentifierStorageDirectory = mediaDeviceIdentifierStorageDirectory; }
> 
> Not sure why this file calls it WTF::String instead of String.

A "String" in this file is an "API::String", which can't be automatically converted to WTF::String. All of the existing methods that return a directory path return "const WTF::String&".

>> Source/WebKit2/UIProcess/API/APIWebsiteDataStore.cpp:116
>> +    // FIXME: Implement
> 
> Normally it’s a period at the end of each of these.
> 
> I don’t understand the status of these functions. Do these really need to be implemented? Or should this be oure virtual instead. Seems a little bit mysterious what the plan is for non-Cocoa, non-GTK platforms. I don’t think our platform independence strategy here is very good.

All of the methods in this class that return Strings (directories) are static (defaultApplicationCacheDirectory, defaultNetworkCacheDirectory, etc). I don't know why it is done this way, but I will talk to Anders.
Comment 8 Eric Carlson 2015-11-09 11:11:48 PST
Created attachment 265075 [details]
Updated patch
Comment 9 Eric Carlson 2015-11-09 12:53:29 PST
Created attachment 265083 [details]
Updated patch
Comment 10 Brent Fulgham 2016-03-10 10:16:05 PST
Comment on attachment 265083 [details]
Updated patch

View in context: https://bugs.webkit.org/attachment.cgi?id=265083&action=review

r=me

> Source/WebKit2/UIProcess/API/APIWebsiteDataStore.cpp:116
> +    // FIXME: Implement

notImplemented()?
Comment 11 Eric Carlson 2016-03-10 11:34:25 PST
Comment on attachment 265083 [details]
Updated patch

This is no longer needed.