Bug 147819 – [font-features] Map OpenType feature tags to TrueType feature selectors

• Component: New Bugs
• Status: RESOLVED FIXED

[Myles C. Maxfield]

[font-features] Map OpenType feature tags to TrueType feature selectors

[Myles C. Maxfield]

Created attachment 258604 [details]
Patch

[Myles C. Maxfield]

Created attachment 258692 [details]
Patch

[Myles C. Maxfield]

Created attachment 258701 [details]
Patch

[Dean Jackson]

Comment on attachment 258701 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=258701&action=review

> Source/WebCore/platform/graphics/cocoa/FontCacheCoreText.cpp:83
> +        if (feature.value() == 1) {
> +            appendRawTrueTypeFeature(features, kLigaturesType, kCommonLigaturesOnSelector);
> +            appendRawTrueTypeFeature(features, kLigaturesType, kContextualLigaturesOnSelector);
> +        } else if (!feature.value()) {

Seems like you do this often enough that I wonder if FontFeature should have a enabled() accessor that checks == 1. But I can't remember at the moment what FontFeature looks like.

> Source/WebCore/platform/graphics/cocoa/FontCacheCoreText.cpp:115
> +        appendRawTrueTypeFeature(features, kLetterCaseType, 14); // we hates this feature

Did you mean to leave this in? If so, please explain.

[Myles C. Maxfield]

Committed r188319: <http://trac.webkit.org/changeset/188319>