Bug 147819

Summary:

[font-features] Map OpenType feature tags to TrueType feature selectors

Product:

WebKit

Reporter:

Myles C. Maxfield <mmaxfield>

Component:

New Bugs

Assignee:

Myles C. Maxfield <mmaxfield>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

benjamin, dino, jonlee, simon.fraser, thorton

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	dino: review+

Description Myles C. Maxfield 2015-08-09 19:09:27 PDT

[font-features] Map OpenType feature tags to TrueType feature selectors

Comment 1 Myles C. Maxfield 2015-08-09 19:11:26 PDT

Created attachment 258604 [details]
Patch

Comment 2 Myles C. Maxfield 2015-08-10 20:14:28 PDT

Created attachment 258692 [details]
Patch

Comment 3 Myles C. Maxfield 2015-08-10 21:32:11 PDT

Created attachment 258701 [details]
Patch

Comment 4 Dean Jackson 2015-08-11 12:09:12 PDT

Comment on attachment 258701 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=258701&action=review

> Source/WebCore/platform/graphics/cocoa/FontCacheCoreText.cpp:83
> +        if (feature.value() == 1) {
> +            appendRawTrueTypeFeature(features, kLigaturesType, kCommonLigaturesOnSelector);
> +            appendRawTrueTypeFeature(features, kLigaturesType, kContextualLigaturesOnSelector);
> +        } else if (!feature.value()) {

Seems like you do this often enough that I wonder if FontFeature should have a enabled() accessor that checks == 1. But I can't remember at the moment what FontFeature looks like.

> Source/WebCore/platform/graphics/cocoa/FontCacheCoreText.cpp:115
> +        appendRawTrueTypeFeature(features, kLetterCaseType, 14); // we hates this feature

Did you mean to leave this in? If so, please explain.

Comment 5 Myles C. Maxfield 2015-08-11 19:00:19 PDT

Committed r188319: <http://trac.webkit.org/changeset/188319>