Error handling padding in box-sizing calculations

• Component: Layout and Rendering
• Status: RESOLVED CONFIGURATION CHANGED

[Brent Fulgham]

Created attachment 258534 [details]
Test case showing the improper behavior

WebKit seems to be taking padding into account when performing height calculations, even when in standards mode using "box-sizing: content-box".

[zalan]

Blink changed available logical height behavior about a year ago. It returns content box height now (vs. border box height)

https://src.chromium.org/viewvc/blink?revision=178693&view=revision

@@ -3085,7 +3061,7 @@ LayoutUnit RenderBox::computeReplacedLogicalHeightUsing(Length logicalHeight) co
 
 LayoutUnit RenderBox::availableLogicalHeight(AvailableLogicalHeightType heightType) const
 {
-    return constrainLogicalHeightByMinMax(availableLogicalHeightUsing(style().logicalHeight(), heightType), -1);
+    return constrainContentBoxLogicalHeightByMinMax(availableLogicalHeightUsing(style().logicalHeight(), heightType), -1);
 }

[Radar WebKit Bug Importer]

<rdar://problem/28213830>

[Ahmad Saleem]

I am not able to reproduce this bug using Safari 16.1 and the "red" square is center similar to Chrome Canary 109 and Firefox Nightly 108.

Do we need to anything else? Thanks!

[Ahmad Saleem]

Also we are passing the test (in STP160) from the Chromium patch of Comment 01:

Test Case - https://jsfiddle.net/0ytgLhwn/

Do we need to do anything else?

[zalan]

(In reply to Ahmad Saleem from comment #4)
> Also we are passing the test (in STP160) from the Chromium patch of Comment
> 01:
> 
> Test Case - https://jsfiddle.net/0ytgLhwn/
> 
> Do we need to do anything else?
Nope, this looks to have progressed. Thanks!