Bug 147792

Summary: Temporarily allow programmatic input assistance for adding Gmail account
Product: WebKit Reporter: Wenson Hsieh <wenson_hsieh>
Component: WebKit2Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, dbates, mitz, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: iPhone / iPad   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch enrica: review+

Description Wenson Hsieh 2015-08-07 13:12:34 PDT
When assisting a node, skip the early return due to no user interaction when we're in Gmail or Yahoo account setup pages.
Comment 1 Wenson Hsieh 2015-08-07 13:18:11 PDT
Actually, it looks like it's just in Gmail settings. There does not appear to be autofocus for the Yahoo Add Account page.
Comment 2 Wenson Hsieh 2015-08-07 13:27:07 PDT
Created attachment 258524 [details]
Patch
Comment 3 Wenson Hsieh 2015-08-07 13:36:01 PDT
Created attachment 258525 [details]
Patch
Comment 4 Daniel Bates 2015-08-07 13:46:13 PDT
<rdar://problem/22126518>
Comment 5 mitz 2015-08-07 14:02:31 PDT
Comment on attachment 258525 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=258525&action=review

> Source/WebCore/platform/RuntimeApplicationChecksIOS.mm:130
> +bool applicationIsGmailAddAccountOnIOS()
> +{
> +    static const bool isGmailAddAccountOnIOS = [[[NSBundle mainBundle] bundleIdentifier] isEqualToString:@"com.apple.social.SLGoogleAuth.SLGoogleAuthService"];
> +    return isGmailAddAccountOnIOS;
> +}
> +

This isn’t the best approach to take here. Adapting WebKit’s behavior to the client is sometimes unavoidable when the client is an application that’s already shipped. But this is not the case here.
Comment 6 Enrica Casucci 2015-08-07 14:02:36 PDT
Comment on attachment 258525 [details]
Patch

Looks good!
Comment 7 Wenson Hsieh 2015-08-07 14:13:05 PDT
Committed r188162: <http://trac.webkit.org/changeset/188162>