Summary: | Temporarily allow programmatic input assistance for adding Gmail account | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Wenson Hsieh <wenson_hsieh> | ||||||
Component: | WebKit2 | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | andersca, dbates, mitz, webkit-bug-importer | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | iPhone / iPad | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Wenson Hsieh
2015-08-07 13:12:34 PDT
Actually, it looks like it's just in Gmail settings. There does not appear to be autofocus for the Yahoo Add Account page. Created attachment 258524 [details]
Patch
Created attachment 258525 [details]
Patch
Comment on attachment 258525 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=258525&action=review > Source/WebCore/platform/RuntimeApplicationChecksIOS.mm:130 > +bool applicationIsGmailAddAccountOnIOS() > +{ > + static const bool isGmailAddAccountOnIOS = [[[NSBundle mainBundle] bundleIdentifier] isEqualToString:@"com.apple.social.SLGoogleAuth.SLGoogleAuthService"]; > + return isGmailAddAccountOnIOS; > +} > + This isn’t the best approach to take here. Adapting WebKit’s behavior to the client is sometimes unavoidable when the client is an application that’s already shipped. But this is not the case here. Comment on attachment 258525 [details]
Patch
Looks good!
Committed r188162: <http://trac.webkit.org/changeset/188162> |