Summary: | [GTK] WTF unit tests are timing out in the bots | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Carlos Garcia Campos <cgarcia> | ||||
Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | fpizlo, ggaren | ||||
Priority: | P2 | Keywords: | Gtk | ||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Carlos Garcia Campos
2015-08-07 02:59:42 PDT
Created attachment 258479 [details]
Patch
Marking WTF_Lock.ContentedShortSection as slow seems to be enough
Comment on attachment 258479 [details]
Patch
Alternatively you could just make the tests run for less time. In each test, the number of iterations is the last argument to the runTest template.
Committed r188125: <http://trac.webkit.org/changeset/188125> Unfortunately this was not enough for the bots, that seem to be slower than my laptop: $ time (../../Tools/jhbuild/jhbuild-wrapper --gtk run xvfb-run bin/TestWebKitAPI/WTF/TestWTF --gtest_filter=WTF_Lock.*) **PASS** WTF_Lock.UncontentedShortSection **PASS** WTF_Lock.UncontentedLongSection **PASS** WTF_Lock.ContentedShortSection **PASS** WTF_Lock.ContentedLongSection **PASS** WTF_Lock.ManyContentedShortSections **PASS** WTF_Lock.ManyContentedLongSections real 0m43.051s user 3m32.349s sys 1m44.799s (In reply to comment #4) > Unfortunately this was not enough for the bots, that seem to be slower than > my laptop: > > $ time (../../Tools/jhbuild/jhbuild-wrapper --gtk run xvfb-run > bin/TestWebKitAPI/WTF/TestWTF --gtest_filter=WTF_Lock.*) > **PASS** WTF_Lock.UncontentedShortSection > **PASS** WTF_Lock.UncontentedLongSection > **PASS** WTF_Lock.ContentedShortSection > **PASS** WTF_Lock.ContentedLongSection > **PASS** WTF_Lock.ManyContentedShortSections > **PASS** WTF_Lock.ManyContentedLongSections > > real 0m43.051s > user 3m32.349s > sys 1m44.799s Increased the timeout for slow tests to timeout * 5 and it stills times out . . . Maybe we should just try to make the test faster. |