Bug 147764

Summary: Move painting functions from RenderObject to RenderElement
Product: WebKit Reporter: zalan <zalan>
Component: Layout and RenderingAssignee: zalan <zalan>
Status: RESOLVED FIXED    
Severity: Normal CC: buildbot, commit-queue, esprehn+autocc, glenn, kondapallykalyan, rniwa, simon.fraser
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
buildbot: commit-queue-
Archive of layout-test-results from ews103 for mac-mavericks
none
Archive of layout-test-results from ews104 for mac-mavericks-wk2
none
Patch
none
Patch
none
Patch none

zalan
Reported 2015-08-06 19:53:09 PDT
Ideally, they should live in RenderBoxModelObject, but svg architecture makes it difficult to move it there.
Attachments
Patch (53.17 KB, patch)
2015-08-06 20:05 PDT, zalan 		no flags
DetailsFormatted DiffDiff
Patch (57.62 KB, patch)
2015-08-06 20:32 PDT, zalan 		no flags
DetailsFormatted DiffDiff
Patch (58.96 KB, patch)
2015-08-06 21:05 PDT, zalan 		buildbot: commit-queue-
DetailsFormatted DiffDiff
Archive of layout-test-results from ews103 for mac-mavericks (678.42 KB, application/zip)
2015-08-06 21:24 PDT, Build Bot 		no flags
Details
Archive of layout-test-results from ews104 for mac-mavericks-wk2 (784.99 KB, application/zip)
2015-08-06 21:45 PDT, Build Bot 		no flags
Details
Patch (61.83 KB, patch)
2015-08-07 09:29 PDT, zalan 		no flags
DetailsFormatted DiffDiff
Patch (67.58 KB, patch)
2015-08-07 14:27 PDT, zalan 		no flags
DetailsFormatted DiffDiff
Patch (67.60 KB, patch)
2015-08-07 14:57 PDT, zalan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.
zalan
Comment 1 2015-08-06 20:05:33 PDT
Created attachment 258434 [details] Patch
zalan
Comment 2 2015-08-06 20:32:32 PDT
Created attachment 258440 [details] Patch
zalan
Comment 3 2015-08-06 21:05:09 PDT
Created attachment 258443 [details] Patch
Build Bot
Comment 4 2015-08-06 21:24:36 PDT
Comment on attachment 258443 [details] Patch Attachment 258443 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/25576 Number of test failures exceeded the failure limit.
Build Bot
Comment 5 2015-08-06 21:24:39 PDT
Created attachment 258445 [details] Archive of layout-test-results from ews103 for mac-mavericks The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews103 Port: mac-mavericks Platform: Mac OS X 10.9.5
Build Bot
Comment 6 2015-08-06 21:45:23 PDT
Comment on attachment 258443 [details] Patch Attachment 258443 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/25644 Number of test failures exceeded the failure limit.
Build Bot
Comment 7 2015-08-06 21:45:26 PDT
Created attachment 258452 [details] Archive of layout-test-results from ews104 for mac-mavericks-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews104 Port: mac-mavericks-wk2 Platform: Mac OS X 10.9.5
zalan
Comment 8 2015-08-07 09:29:54 PDT
Created attachment 258506 [details] Patch
Simon Fraser (smfr)
Comment 9 2015-08-07 13:24:11 PDT
Comment on attachment 258506 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=258506&action=review > Source/WebCore/rendering/RenderElement.cpp:1977 > + // FIXME: These roundings should be replaced by ASSERT(device pixel positioned) when all the callers transitioned to device pixels. *have* transitioned > Source/WebCore/rendering/RenderElement.h:211 > + void drawLineForBoxSide(GraphicsContext&, const FloatRect&, BoxSide, Color, EBorderStyle, float adjbw1, float adjbw2, bool antialias = false) const; adjbw1, adjbw2 :|
zalan
Comment 10 2015-08-07 14:27:28 PDT
Created attachment 258528 [details] Patch
zalan
Comment 11 2015-08-07 14:57:03 PDT
Created attachment 258532 [details] Patch
WebKit Commit Bot
Comment 12 2015-08-07 20:07:08 PDT
Comment on attachment 258532 [details] Patch Clearing flags on attachment: 258532 Committed r188183: <http://trac.webkit.org/changeset/188183>
WebKit Commit Bot
Comment 13 2015-08-07 20:07:13 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.