Summary: | Move painting functions from RenderObject to RenderElement | ||||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | zalan <zalan> | ||||||||||||||||||
Component: | Layout and Rendering | Assignee: | zalan <zalan> | ||||||||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||||||||
Severity: | Normal | CC: | buildbot, commit-queue, esprehn+autocc, glenn, kondapallykalyan, rniwa, simon.fraser | ||||||||||||||||||
Priority: | P2 | ||||||||||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||||||||||
Hardware: | Unspecified | ||||||||||||||||||||
OS: | Unspecified | ||||||||||||||||||||
Attachments: |
|
Description
zalan
2015-08-06 19:53:09 PDT
Created attachment 258434 [details]
Patch
Created attachment 258440 [details]
Patch
Created attachment 258443 [details]
Patch
Comment on attachment 258443 [details] Patch Attachment 258443 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/25576 Number of test failures exceeded the failure limit. Created attachment 258445 [details]
Archive of layout-test-results from ews103 for mac-mavericks
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103 Port: mac-mavericks Platform: Mac OS X 10.9.5
Comment on attachment 258443 [details] Patch Attachment 258443 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/25644 Number of test failures exceeded the failure limit. Created attachment 258452 [details]
Archive of layout-test-results from ews104 for mac-mavericks-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104 Port: mac-mavericks-wk2 Platform: Mac OS X 10.9.5
Created attachment 258506 [details]
Patch
Comment on attachment 258506 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=258506&action=review > Source/WebCore/rendering/RenderElement.cpp:1977 > + // FIXME: These roundings should be replaced by ASSERT(device pixel positioned) when all the callers transitioned to device pixels. *have* transitioned > Source/WebCore/rendering/RenderElement.h:211 > + void drawLineForBoxSide(GraphicsContext&, const FloatRect&, BoxSide, Color, EBorderStyle, float adjbw1, float adjbw2, bool antialias = false) const; adjbw1, adjbw2 :| Created attachment 258528 [details]
Patch
Created attachment 258532 [details]
Patch
Comment on attachment 258532 [details] Patch Clearing flags on attachment: 258532 Committed r188183: <http://trac.webkit.org/changeset/188183> All reviewed patches have been landed. Closing bug. |