Bug 147764 - Move painting functions from RenderObject to RenderElement
Summary: Move painting functions from RenderObject to RenderElement
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-08-06 19:53 PDT by zalan
Modified: 2015-08-07 20:07 PDT (History)
7 users (show)

See Also:


Attachments
Patch (53.17 KB, patch)
2015-08-06 20:05 PDT, zalan
no flags Details | Formatted Diff | Diff
Patch (57.62 KB, patch)
2015-08-06 20:32 PDT, zalan
no flags Details | Formatted Diff | Diff
Patch (58.96 KB, patch)
2015-08-06 21:05 PDT, zalan
buildbot: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ews103 for mac-mavericks (678.42 KB, application/zip)
2015-08-06 21:24 PDT, Build Bot
no flags Details
Archive of layout-test-results from ews104 for mac-mavericks-wk2 (784.99 KB, application/zip)
2015-08-06 21:45 PDT, Build Bot
no flags Details
Patch (61.83 KB, patch)
2015-08-07 09:29 PDT, zalan
no flags Details | Formatted Diff | Diff
Patch (67.58 KB, patch)
2015-08-07 14:27 PDT, zalan
no flags Details | Formatted Diff | Diff
Patch (67.60 KB, patch)
2015-08-07 14:57 PDT, zalan
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2015-08-06 19:53:09 PDT
Ideally, they should live in RenderBoxModelObject, but svg architecture makes it difficult to move it there.
Comment 1 zalan 2015-08-06 20:05:33 PDT
Created attachment 258434 [details]
Patch
Comment 2 zalan 2015-08-06 20:32:32 PDT
Created attachment 258440 [details]
Patch
Comment 3 zalan 2015-08-06 21:05:09 PDT
Created attachment 258443 [details]
Patch
Comment 4 Build Bot 2015-08-06 21:24:36 PDT
Comment on attachment 258443 [details]
Patch

Attachment 258443 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/25576

Number of test failures exceeded the failure limit.
Comment 5 Build Bot 2015-08-06 21:24:39 PDT
Created attachment 258445 [details]
Archive of layout-test-results from ews103 for mac-mavericks

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103  Port: mac-mavericks  Platform: Mac OS X 10.9.5
Comment 6 Build Bot 2015-08-06 21:45:23 PDT
Comment on attachment 258443 [details]
Patch

Attachment 258443 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/25644

Number of test failures exceeded the failure limit.
Comment 7 Build Bot 2015-08-06 21:45:26 PDT
Created attachment 258452 [details]
Archive of layout-test-results from ews104 for mac-mavericks-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104  Port: mac-mavericks-wk2  Platform: Mac OS X 10.9.5
Comment 8 zalan 2015-08-07 09:29:54 PDT
Created attachment 258506 [details]
Patch
Comment 9 Simon Fraser (smfr) 2015-08-07 13:24:11 PDT
Comment on attachment 258506 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=258506&action=review

> Source/WebCore/rendering/RenderElement.cpp:1977
> +        // FIXME: These roundings should be replaced by ASSERT(device pixel positioned) when all the callers transitioned to device pixels.

*have* transitioned

> Source/WebCore/rendering/RenderElement.h:211
> +    void drawLineForBoxSide(GraphicsContext&, const FloatRect&, BoxSide, Color, EBorderStyle, float adjbw1, float adjbw2, bool antialias = false) const;

adjbw1, adjbw2 :|
Comment 10 zalan 2015-08-07 14:27:28 PDT
Created attachment 258528 [details]
Patch
Comment 11 zalan 2015-08-07 14:57:03 PDT
Created attachment 258532 [details]
Patch
Comment 12 WebKit Commit Bot 2015-08-07 20:07:08 PDT
Comment on attachment 258532 [details]
Patch

Clearing flags on attachment: 258532

Committed r188183: <http://trac.webkit.org/changeset/188183>
Comment 13 WebKit Commit Bot 2015-08-07 20:07:13 PDT
All reviewed patches have been landed.  Closing bug.