Bug 147750

Summary: Structures used for tryGetConstantProperty() should be registered first
Product: WebKit Reporter: Filip Pizlo <fpizlo>
Component: JavaScriptCoreAssignee: Filip Pizlo <fpizlo>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
the patch fpizlo: review+

Description Filip Pizlo 2015-08-06 15:07:22 PDT 
Patch forthcoming.
Comment 1 Filip Pizlo 2015-08-06 15:11:15 PDT 
Created attachment 258406 [details]
the patch
Comment 2 Saam Barati 2015-08-06 15:34:18 PDT 
Comment on attachment 258406 [details]
the patch

r=me
Comment 3 Michael Saboff 2015-08-06 15:34:51 PDT 
Comment on attachment 258406 [details]
the patch

View in context: https://bugs.webkit.org/attachment.cgi?id=258406&action=review

r=me

> Source/JavaScriptCore/ChangeLog:9
> +        (JSC::DFG::Graph::tryGetConstantProperty): Add an assertion that effect. This should catch the bug sooner.

Should the wording be "to that effect"?
Comment 4 Filip Pizlo 2015-08-06 15:36:00 PDT 
Comment on attachment 258406 [details]
the patch

This was reviewed by both Michael and Saam.
Comment 5 Filip Pizlo 2015-08-06 15:36:15 PDT 
(In reply to comment #3)
> Comment on attachment 258406 [details]
> the patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=258406&action=review
> 
> r=me
> 
> > Source/JavaScriptCore/ChangeLog:9
> > +        (JSC::DFG::Graph::tryGetConstantProperty): Add an assertion that effect. This should catch the bug sooner.
> 
> Should the wording be "to that effect"?

Yup, fixed.
Comment 6 Filip Pizlo 2015-08-06 15:37:29 PDT 
Landed in http://trac.webkit.org/changeset/188067