Bug 147720

Summary:

Web Inspector: Autocompletion previews in the CSS sidebar do not apply

Product:

WebKit

Reporter:

Devin Rousso <hi>

Component:

Web Inspector

Assignee:

Devin Rousso <hi>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bburg, commit-queue, graouts, joepeck, mattbaker, nvasilyev, timothy, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

See Also:

https://bugs.webkit.org/show_bug.cgi?id=147975

Bug Depends on:

Bug Blocks:

150537

Attachments:

Description	Flags
Patch	none

Description Devin Rousso 2015-08-05 21:26:01 PDT

* STEPS TO REPRODUCE:
1. Go to apple.com and open the inspector on the Elements tab with the Rules panel
2. Type "position: " and then hit escape to open the completions view
3. Press the Up or Down arrows to move between completions

Expected:
When "absolute" or "fixed" are highlighted, the selected element's style should change based off the new position attribute

Actual:
Nothing changes.

Comment 1 Devin Rousso 2015-08-06 14:39:46 PDT

I have opened an issue with CodeMirror to add a feature that should allow this to work.
https://github.com/codemirror/CodeMirror/issues/3436

Comment 2 Devin Rousso 2015-10-21 16:08:04 PDT

Created attachment 263756 [details]
Patch

Comment 3 Radar WebKit Bug Importer 2015-10-21 16:08:44 PDT

<rdar://problem/23210563>

Comment 4 Radar WebKit Bug Importer 2015-10-21 16:08:57 PDT

<rdar://problem/23210565>

Comment 5 WebKit Commit Bot 2015-10-21 17:32:05 PDT

Comment on attachment 263756 [details]
Patch

Clearing flags on attachment: 263756

Committed r191419: <http://trac.webkit.org/changeset/191419>

Comment 6 WebKit Commit Bot 2015-10-21 17:32:14 PDT

All reviewed patches have been landed.  Closing bug.

Comment 7 Joseph Pecoraro 2016-02-04 10:55:51 PST

Hmm, this appeared to stop working again recently.

Comment 8 Devin Rousso 2016-02-04 12:06:36 PST

(In reply to comment #7)
> Hmm, this appeared to stop working again recently.

This actually hasn't been working for a while (as far as I remember).  If I recall correctly, these changes caused problems when typing in the Styles sidebar (<https://bugs.webkit.org/show_bug.cgi?id=150493>) and were rolled back in <https://bugs.webkit.org/show_bug.cgi?id=150537>.  I have done some research, but honestly I'm not sure how to properly ensure that the undo() action only fires when autocompletion previews are visible (while also doing something special when an autocompletion preview is selected and applied).  I'll try taking another look this weekend.