Bug 147716

Summary: Automate JSBench with run-benchmark
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: Tools / TestsAssignee: Ryosuke Niwa <rniwa>
Status: RESOLVED FIXED    
Severity: Normal CC: barraclough, benjamin, cdumez, commit-queue, dewei_zhu, fpizlo, ggaren, glenn, kling
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Added jsbench.plan cdumez: review+

Ryosuke Niwa
Reported 2015-08-05 19:04:32 PDT
run-benchmark should support JSBench.
Attachments
Added jsbench.plan (15.05 KB, patch)
2015-08-05 19:09 PDT, Ryosuke Niwa 		cdumez: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1 2015-08-05 19:09:39 PDT
Created attachment 258336 [details] Added jsbench.plan
Chris Dumez
Comment 2 2015-08-06 13:39:09 PDT
Comment on attachment 258336 [details] Added jsbench.plan View in context: https://bugs.webkit.org/attachment.cgi?id=258336&action=review r=me with a suggestion. > Tools/Scripts/webkitpy/benchmark_runner/data/plans/dromaeo-jslib.plan:7 > + "remote_archive_type": "zip", It seems like we could detect the archive type based on the file extension of the remote_archive after it was downloaded. This would avoid adding an extra field to the plan..
Ryosuke Niwa
Comment 3 2015-08-06 15:23:42 PDT
Committed r188065: <http://trac.webkit.org/changeset/188065>
Note You need to log in before you can comment on or make changes to this bug.