Bug 147694

Summary: Subtree layout code should use RenderElement.
Product: WebKit Reporter: zalan <zalan>
Component: Layout and RenderingAssignee: zalan <zalan>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, commit-queue, esprehn+autocc, glenn, kling, kondapallykalyan
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Description zalan 2015-08-05 14:43:32 PDT 
...instead of RenderObject.
Comment 1 zalan 2015-08-05 14:47:09 PDT 
Created attachment 258301 [details]
Patch
Comment 2 Chris Dumez 2015-08-05 14:50:46 PDT 
Comment on attachment 258301 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=258301&action=review

> Source/WebCore/inspector/InspectorTimelineAgent.cpp:352
> +    RenderElement* root = frame.view()->layoutRoot();

nit: auto* would be nice.

> Source/WebCore/page/FrameView.h:120
> +    RenderElement* layoutRoot()const { return m_layoutRoot; }

nit: Missing space before 'const'.
Comment 3 Chris Dumez 2015-08-05 14:51:37 PDT 
Sorry, did not mean to override Simon's r+.
Comment 4 zalan 2015-08-05 15:01:28 PDT 
Created attachment 258303 [details]
Patch
Comment 5 WebKit Commit Bot 2015-08-07 14:25:50 PDT 
Comment on attachment 258303 [details]
Patch

Clearing flags on attachment: 258303

Committed r188163: <http://trac.webkit.org/changeset/188163>
Comment 6 WebKit Commit Bot 2015-08-07 14:25:54 PDT 
All reviewed patches have been landed.  Closing bug.