Bug 147688

Summary: Bytecodegenerator emits crappy code for returns in a lexical scope.
Product: WebKit Reporter: Saam Barati <saam>
Component: JavaScriptCoreAssignee: Saam Barati <saam>
Status: RESOLVED FIXED    
Severity: Normal CC: basile_clement, benjamin, fpizlo, ggaren, mark.lam, mmirman, msaboff, oliver, ysuzuki
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch mark.lam: review+

Description Saam Barati 2015-08-05 11:10:47 PDT 
I introduced bad codegen in r187003 by having returns first pop to scope depth zero, always when there is local scope depth.
This is *only* necessary if we have "finally" blocks.
This should be an easy fix.
Comment 1 Saam Barati 2015-08-05 11:38:24 PDT 
Created attachment 258289 [details]
patch
Comment 2 Mark Lam 2015-08-05 14:32:05 PDT 
Comment on attachment 258289 [details]
patch

r=me

nit: Can you add a comment in the ChangeLog to indicate that this is a perf bug, and not a correctness bug?
Comment 3 Saam Barati 2015-08-05 14:46:06 PDT 
landed in:
http://trac.webkit.org/changeset/187991