Bug 147688

Summary: Bytecodegenerator emits crappy code for returns in a lexical scope.
Product: WebKit Reporter: Saam Barati <saam>
Component: JavaScriptCoreAssignee: Saam Barati <saam>
Status: RESOLVED FIXED    
Severity: Normal CC: basile_clement, benjamin, fpizlo, ggaren, mark.lam, mmirman, msaboff, oliver, ysuzuki
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch mark.lam: review+

Saam Barati
Reported 2015-08-05 11:10:47 PDT
I introduced bad codegen in r187003 by having returns first pop to scope depth zero, always when there is local scope depth. This is *only* necessary if we have "finally" blocks. This should be an easy fix.
Attachments
patch (2.41 KB, patch)
2015-08-05 11:38 PDT, Saam Barati 		mark.lam: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Saam Barati
Comment 1 2015-08-05 11:38:24 PDT
Created attachment 258289 [details] patch
Mark Lam
Comment 2 2015-08-05 14:32:05 PDT
Comment on attachment 258289 [details] patch r=me nit: Can you add a comment in the ChangeLog to indicate that this is a perf bug, and not a correctness bug?
Saam Barati
Comment 3 2015-08-05 14:46:06 PDT
landed in: http://trac.webkit.org/changeset/187991
Note You need to log in before you can comment on or make changes to this bug.