Bug 147688 - Bytecodegenerator emits crappy code for returns in a lexical scope.
Summary: Bytecodegenerator emits crappy code for returns in a lexical scope.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Saam Barati
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-08-05 11:10 PDT by Saam Barati
Modified: 2022-02-27 23:37 PST (History)
9 users (show)

See Also:

Attachments
patch (2.41 KB, patch)
2015-08-05 11:38 PDT, Saam Barati 		mark.lam: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Saam Barati 2015-08-05 11:10:47 PDT 
I introduced bad codegen in r187003 by having returns first pop to scope depth zero, always when there is local scope depth.
This is *only* necessary if we have "finally" blocks.
This should be an easy fix.
Comment 1 Saam Barati 2015-08-05 11:38:24 PDT 
Created attachment 258289 [details]
patch
Comment 2 Mark Lam 2015-08-05 14:32:05 PDT 
Comment on attachment 258289 [details]
patch

r=me

nit: Can you add a comment in the ChangeLog to indicate that this is a perf bug, and not a correctness bug?
Comment 3 Saam Barati 2015-08-05 14:46:06 PDT 
landed in:
http://trac.webkit.org/changeset/187991