Bug 147662

Summary:

Web Inspector: Don't show "No Filter Results" when timeline is empty

Product:

WebKit

Reporter:

Matt Baker <mattbaker>

Component:

Web Inspector

Assignee:

Devin Rousso <hi>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bburg, commit-queue, graouts, hi, joepeck, mattbaker, nvasilyev, timothy, webkit-bug-importer

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch	none

Description Matt Baker 2015-08-04 16:28:06 PDT

* SUMMARY
Don't show "No Filter Results" when timeline is empty.

* STEPS TO REPRODUCE
1. Record some timeline data
2. Enter nonsense filter text, "No Filter Results" appears
3. Clear timeline
4. Clear filter text
  => "No Filter Results" is still displayed

* NOTES
The "No Filter Results" text sometimes appears after clearing a timeline for which no filters were ever applied, but I haven't been able to consistently reproduce this case.

Comment 1 Devin Rousso 2015-08-08 17:01:36 PDT

Created attachment 258580 [details]
Patch

Comment 2 WebKit Commit Bot 2015-08-08 18:22:24 PDT

Comment on attachment 258580 [details]
Patch

Clearing flags on attachment: 258580

Committed r188191: <http://trac.webkit.org/changeset/188191>

Comment 3 WebKit Commit Bot 2015-08-08 18:22:28 PDT

All reviewed patches have been landed.  Closing bug.