Bug 147657

Summary: Replace JSFunctionNameScope with JSLexicalEnvironment for the function name scope.
Product: WebKit Reporter: Saam Barati <saam>
Component: JavaScriptCoreAssignee: Saam Barati <saam>
Status: RESOLVED FIXED    
Severity: Normal CC: basile_clement, benjamin, fpizlo, ggaren, mark.lam, mmirman, msaboff, oliver, ysuzuki
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 147666    
Attachments:
Description Flags
patch mark.lam: review+, mark.lam: commit-queue-

Description Saam Barati 2015-08-04 15:35:00 PDT
We can just implement this as a "const"-like scope :)
Comment 1 Saam Barati 2015-08-04 19:05:51 PDT
Created attachment 258257 [details]
patch
Comment 2 Mark Lam 2015-08-05 09:44:43 PDT
Comment on attachment 258257 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=258257&action=review

r=me with fixes.

Do we already have test coverage for all the aspects of the function name scope behavior?  If not, please add the missing pieces.

> Source/JavaScriptCore/ChangeLog:14
> +        this variable like a "const" because 

You're cut off here mid thought.
Comment 3 Saam Barati 2015-08-05 11:16:44 PDT
(In reply to comment #2)
> Comment on attachment 258257 [details]
> patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=258257&action=review
> 
> r=me with fixes.
> 
> Do we already have test coverage for all the aspects of the function name
> scope behavior?  If not, please add the missing pieces.
> 
We do have tests. I broke them and then fixed them :)

> > Source/JavaScriptCore/ChangeLog:14
> > +        this variable like a "const" because 
> 
> You're cut off here mid thought.
Fixed.
Comment 4 Saam Barati 2015-08-05 11:30:20 PDT
landed in:
http://trac.webkit.org/changeset/187969