Bug 147655

Summary: Improve some LayoutTests/inspector flakey output for tests with InspectorTest.reloadPage
Product: WebKit Reporter: Joseph Pecoraro <joepeck>
Component: Web InspectorAssignee: Joseph Pecoraro <joepeck>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, bburg, commit-queue, graouts, joepeck, jonowells, mattbaker, nvasilyev, simon.fraser, timothy, webkit-bug-importer
Priority: P2 Keywords: DoNotImportToRadar
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
[PATCH] Proposed Fix none

Joseph Pecoraro
Reported 2015-08-04 15:10:21 PDT
* SUMMARY Improve some LayoutTests/inspector flakey output for tests with InspectorTest.reloadPage. I was seeing an issue where tests with reloadPage might duplicate some output. After much logging, it appears to be related to ordering of operations. A test might call InspectorTest.reloadPage, but before the callback runs to say "test is reloading" another InspectorTest.log would sneak and send a result, then get resent once the page loads. Making InspectorTest.reloadPage immediately say "we are reloading" removes the flakiness, as the early InspectorTest.log wouldn't send its message as it knows it will be resent after the reload.
Attachments
[PATCH] Proposed Fix (3.11 KB, patch)
2015-08-04 15:14 PDT, Joseph Pecoraro 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Joseph Pecoraro
Comment 1 2015-08-04 15:11:19 PDT
* STEPS TO REPRODUCE 1. shell> run-webkit-tests --release --no-retry-failures --iterations=1000 inspector/page/main-frame-resource.html => 10 failures out of 1000 runs for me.
Joseph Pecoraro
Comment 2 2015-08-04 15:11:46 PDT
Err, throw a "--v" on there as well to see the result of each test run.
Joseph Pecoraro
Comment 3 2015-08-04 15:13:55 PDT
*** Bug 147517 has been marked as a duplicate of this bug. ***
Joseph Pecoraro
Comment 4 2015-08-04 15:14:15 PDT
Created attachment 258218 [details] [PATCH] Proposed Fix
WebKit Commit Bot
Comment 5 2015-08-04 15:51:01 PDT
Comment on attachment 258218 [details] [PATCH] Proposed Fix Clearing flags on attachment: 258218 Committed r187903: <http://trac.webkit.org/changeset/187903>
WebKit Commit Bot
Comment 6 2015-08-04 15:51:04 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.